Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add Dark Mode Support #1874

Closed
wants to merge 2 commits into from
Closed

Conversation

Keshraf
Copy link

@Keshraf Keshraf commented Oct 3, 2022

Fixes Issue

Closes #1838

Changes proposed

  1. Added Dark Mode Support in Tailwind Config File
  2. Installed next-themes package which enables us to change to dark mode programmatically
  3. Added Dark Mode Toggle Button
  4. Fixed Text that weren't changing on switching

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2022-10-03 at 8 04 21 PM

Screenshot 2022-10-03 at 8 04 29 PM

Screenshot 2022-10-03 at 8 04 55 PM

Screenshot 2022-10-03 at 8 05 07 PM

Note to reviewers

I found that the menu button for mobile-view doesn't work, should I create a new issue and PR for it?

Installed next-themes package & wrapped the application with ThemesProvider
Used emojis to convey mode & added dark class to text
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Keshraf
Copy link
Author

Keshraf commented Oct 3, 2022

How can I fix this?

I would also be open to suggestions on my work.

@eddiejaoude
Copy link
Member

Sorry @Keshraf for my slow reply, I will take a look today

@eddiejaoude
Copy link
Member

I found that the menu button for mobile-view doesn't work, should I create a new issue and PR for it?

I just saw your comment @Keshraf, it would be better to fix it in this PR

@Keshraf
Copy link
Author

Keshraf commented Oct 13, 2022

Okay @eddiejaoude, I will fix it in this PR 👍

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Oct 13, 2022
@github-actions
Copy link
Contributor

Welcome @Keshraf! Thank you so much for your first pull request!

@github-actions github-actions bot added the v2 label Oct 13, 2022
@eddiejaoude
Copy link
Member

Sorry @Keshraf I just realised we might be talking about different menu buttons. Are you talking about the light/dark mode or the "hamburger" one? If for the existing button that is not required for this PR, sorry I assumed you meant for your new button

Please clarify and we can hopefully get this merged soon, thanks 👍

@Keshraf
Copy link
Author

Keshraf commented Oct 28, 2022

Sorry @Keshraf I just realised we might be talking about different menu buttons. Are you talking about the light/dark mode or the "hamburger" one? If for the existing button that is not required for this PR, sorry I assumed you meant for your new button

Please clarify and we can hopefully get this merged soon, thanks 👍

I was talking about the "hamburger menu" button. Should I add it to this PR?

@eddiejaoude
Copy link
Member

Yes please, if you can add it to this PR as it is related to the changes here 👍

Sorry you have some conflicts to resolve now because other PRs have been merged in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request with more than 30 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants