This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Moves menubar in header #1457
Merged
Moves menubar in header #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
EmmaDawsonDev
approved these changes
Jul 12, 2022
|
Oh, there appears to be a merge conflict in the Home component. If you could fix that then this should be good to merge. __ |
|
I will get fixing! |
|
I have resolved the conflicts! It should be good to merge it now👍🏻 |
|
Thank you, @eddiejaoude and @emmalearnscode 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #1437
Changes proposed
Moves the menu bar in all three pages (home, search and profile) outside the main element and into the header element.
Check List (Check all the applicable boxes)
Screenshots
Home page:
Search page:
Profile page:
