This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Custom title pr 968 #1475
Merged
Custom title pr 968 #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The profile document title is changing based on the name of the user fix - Added document.title to the useEffect of User.js file - The user name will be displayed on the document title - Added the cleanup function to revert back to original document title
Removed file to comply with PR specifications
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
schmelto
reviewed
Jul 11, 2022
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
|
Well spotted Tom, updated it now. |
schmelto
approved these changes
Jul 11, 2022
This was referenced Jul 11, 2022
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #964
The creator of PR #968 never came back to fix a merge conflict although the changes were very good. Instead I created a new branch, merged their changes there and fixed the conflicting files (package-lock.json). I have also merged in all current changes since the PR was from January. Prettier has adjusted some of the files, but the main changes were to the user profile.