Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Updated back arrow to navigate to correct page #1482

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Updated back arrow to navigate to correct page #1482

merged 3 commits into from
Jul 12, 2022

Conversation

andrewkykoo
Copy link
Contributor

@andrewkykoo andrewkykoo commented Jul 11, 2022

Fixes Issue

Closes #1478

Changes proposed

  • Updated the Link component's to prop to '/search' in Navbar component in User component

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screen.Recording.2022-07-11.at.4.51.54.PM.mov

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Revert the changes from the package-lock.json file! Let us know If you need any help!

src/Components/UserProfile/User.js Outdated Show resolved Hide resolved
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for contributing! 🚀

Summary: Code looks Good. | Tags: Maintainable

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks for your contribution!

__
sema-logo  Summary: 🏆 This code is awesome

@EmmaDawsonDev EmmaDawsonDev merged commit d9d3ce4 into EddieHubCommunity:main Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Back arrow navigates to wrong page
3 participants