-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Welcome @lmac-1! Thank you so much for your first pull request! |
Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest. |
public/data/lmac-1.json
Outdated
"color": "black", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove this field if you're not going to use it, IMO.
"color": "black", | |
"description": "" | |
"color": "black" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it! Will make the changes today, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the unnecessary line. Let me know if anything else is incorrect. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profile looks good to me, but accidentally you've committed icons.md
, so please revert the changes in the icons.md
file!
PR adding profile should only contain your file!
Changes proposed
Adds Lucy Macartney's profile to LinkFree
Check List (Check all the applicable boxes)