-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix [BUG] Icon copy notification text is not readable as the underlying elements are also visible. #9652
Conversation
…ng elements are also visible. #9618
Hey @mrinmay7875, I was thinking, what if we bumped up the z-index for the notification or alert instead of removing it from the navbar? Removing the navbar's z-index might potentially affect other components, and I thought this could be a more targeted solution. What do you reckon? |
@Kamaruddheen I did test it well but could not find any area where it is broken due to removing the z-index from navbar. Let's see what the maintainers say about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I agree with the other review, is it possible to increase the z-index of the alert notification?
It should be possible if we are generating a alert template from our end. |
I could see alert.js file which is generating alerts based on success, errors, warning and info. If we increase the z-index of those class we should also get the same result. |
After some investigation, I've pinpointed the actual bug. It turns out that z-40 is already defined in the Notification component, specifically on line no. 54 BioDrop/components/Notification.js Lines 52 to 72 in 64fa44d
I attempted to include the z-index within a |
The To visualize how these z-index values affect the layering, biodrop_error.mp4To resolve this matter, a straightforward solution would be to raise the z-index value in the biodrop_zindex_solution.mp4 |
I am busy with some personal stuff. @Kamaruddheen You can take this over if you want and create a PR with your changes. |
Okay @mrinmay7875, I think I might be able to commit in this PR branch. |
@mrinmay7875 if you cannot work on an issue please unassign yourself. I will do this for you on this occasion. @Kamaruddheen committing to someone else's PR would cause confusion and extra admin, so please raise a new PR. I will assign the issue to you. As a result of the above conversation I am closing this PR. |
Closes #9618
Fixes Issue
This PR fixes #9618
Changes proposed
Screenshots
Here is a screenshot after my fix: