Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

fix: add abhinavkashyap061 #1143

Merged
merged 5 commits into from Jun 1, 2022
Merged

fix: add abhinavkashyap061 #1143

merged 5 commits into from Jun 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2022

resolves #1142

Checklist for profile addition

  • Name the PR fix: add <your-username>.
  • You've added file named your-username.json in the profiles directory.
  • You've linked the PR to the correct issue.

Other additions/changes

  • Changes made in this PR are mentioned below
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.
  • I've read the contributing guidelines

This PR adds/fixes

Notes

profiles/abhinavkashyap061.json Outdated Show resolved Hide resolved
Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__
sema-logo  Summary: 👌 This code looks good

@ghost
Copy link
Author

ghost commented May 31, 2022

  • ok thanks! do I need to do anything else?? i am a newbie open source contributor 😅

@schmelto schmelto requested a review from Panquesito7 May 31, 2022 11:35
@schmelto
Copy link
Contributor

  • ok thanks! do I need to do anything else?? i am a newbie open source contributor 😅

No all good. Just wait for another maintainer to approve the PR and than this will get merged.

__
sema-logo  Summary: 👌 This code looks good

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

__
sema-logo  Summary: 👌 This code looks good

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 merged commit f2e336b into EddieHubCommunity:main Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abhinav Kashyap
4 participants