Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

fix: add devpatricia #1169

Merged
merged 5 commits into from
Jun 18, 2022
Merged

fix: add devpatricia #1169

merged 5 commits into from
Jun 18, 2022

Conversation

icodeando
Copy link
Contributor

@icodeando icodeando commented Jun 13, 2022 •
edited
Loading

resolve #issueNumber #1168

resolves #issueNumber

Checklist for profile addition

  • Name the PR fix: add <your-username>.
  • You've added file named your-username.json in the profiles directory.
  • You've linked the PR to the correct issue.

Other additions/changes

  • Changes made in this PR are mentioned below
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.
  • I've read the contributing guidelines

This PR adds/fixes

Notes

icodeando
icodeando commented Jun 13, 2022
View reviewed changes
Copy link
Contributor Author

@icodeando icodeando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed last name

Pradumnasaraf
Pradumnasaraf suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Everything looks good, but some minor changes needed 😄

__
sema-logo  Summary: 👌 This code looks good

profiles/patriciadiaz.json Outdated Show resolved Hide resolved
@icodeando @Pradumnasaraf
Update profiles/patriciadiaz.json
fff1b79 
Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
@pranay202
Copy link
Member

Hey @devPatricia, everything looks good. Just add one extra line at the end of the code.

Pradumnasaraf
Pradumnasaraf suggested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, just add one extra line!

profiles/patriciadiaz.json Outdated Show resolved Hide resolved
@icodeando @Pradumnasaraf
Update profiles/patriciadiaz.json
fe57d37 
Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
Panquesito7
Panquesito7 suggested changes Jun 15, 2022
View reviewed changes
profiles/patriciadiaz.json Outdated Show resolved Hide resolved
@icodeando @Panquesito7
Update profiles/patriciadiaz.json
0bf9875 
Co-authored-by: David Leal <halfpacho@gmail.com>
schmelto
schmelto approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

Your suggested changes looking good to me.
__
sema-logo  Summary: 👌 This code looks good  |  Tags: Elegant

@schmelto schmelto merged commit 6dba358 into EddieHubCommunity:main Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@schmelto schmelto schmelto approved these changes

@Pradumnasaraf Pradumnasaraf Awaiting requested review from Pradumnasaraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icodeando @pranay202 @schmelto @Panquesito7 @Pradumnasaraf