Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

fix: add ksaurabh4 #1180

Merged
merged 2 commits into from
Jun 17, 2022
Merged

fix: add ksaurabh4 #1180

merged 2 commits into from
Jun 17, 2022

Conversation

ksaurabh4
Copy link
Contributor

resolves ##1179

Checklist for profile addition

  • Name the PR fix: add <your-username>.
  • You've added file named your-username.json in the profiles directory.
  • You've linked the PR to the correct issue.

Other additions/changes

  • Changes made in this PR are mentioned below
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.
  • I've read the contributing guidelines

This PR adds/fixes

Notes

Pradumnasaraf
Pradumnasaraf suggested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will recommend using this image,as your profile looks much better in this :)

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Reusable

profiles/kumar-saurabh.json Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after @Pradumnasaraf's suggestion.

@ksaurabh4 @Pradumnasaraf
Update profiles/kumar-saurabh.json
75293d6 
Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
@ksaurabh4
Copy link
Contributor Author

I will recommend using this image,as your profile looks much better in this :)

__ sema-logo sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Reusable

Thanks for the suggested Image 👍 I have committed the suggested change as well.

@ksaurabh4 ksaurabh4 requested a review from Pradumnasaraf June 16, 2022 01:58
Pradumnasaraf
Pradumnasaraf approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggested changes. Looks good to merge 👍

__
sema-logo  Summary: 👌 This code looks good

@Pradumnasaraf Pradumnasaraf merged commit b5711f1 into EddieHubCommunity:main Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksaurabh4 @Panquesito7 @Pradumnasaraf