Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

fix: update imlakshay08.json #1345

Merged
merged 2 commits into from
Aug 31, 2022
Merged

fix: update imlakshay08.json #1345

merged 2 commits into from
Aug 31, 2022

Conversation

imlakshay08
Copy link
Member

@imlakshay08 imlakshay08 commented Aug 30, 2022 •
edited
Loading

resolves #1344

Checklist for profile addition

  • Name the PR fix: add <your-username>.
  • You've added file named your-username.json in the profiles directory.
  • You've linked the PR to the correct issue.

Other additions/changes

  • Changes made in this PR are mentioned below
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.
  • I've read the contributing guidelines

This PR adds/fixes

Notes

@imlakshay08 imlakshay08 mentioned this pull request Aug 30, 2022
Closed
7 tasks
Pradumnasaraf
Pradumnasaraf reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you have 2 PRs open, close another one and resolve the merge conflict in this one!

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not reusable

@imlakshay08
Copy link
Member Author

imlakshay08 commented Aug 30, 2022 •
edited
Loading

Hey, you have 2 PRs open, close another one and resolve the merge conflict in this one!

__ sema-logo sema-logo Summary: hammer_and_wrench This code needs a fix | Tags: Not reusable

I have closed the other one but not able to resolve this one.

@Pradumnasaraf
Copy link
Contributor

Did it for you, so you are updating your profile, instead of adding it, correct?

__
sema-logo  Summary: ❓ I have a question

@imlakshay08
Copy link
Member Author

imlakshay08 commented Aug 30, 2022 •
edited
Loading

Did it for you, so you are updating your profile, instead of adding it, correct?

__ sema-logo sema-logo Summary: question I have a question

Yes. Thank you so much for doing it.

Panquesito7
Panquesito7 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎉

__
sema-logo  Summary: 👌 This code looks good

@Pradumnasaraf Pradumnasaraf changed the title fix: add imlakshay08.json fix: update imlakshay08.json Aug 31, 2022
Pradumnasaraf
Pradumnasaraf approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thank you for your contributions 🎉

__
sema-logo  Summary: 🏆 This code is awesome

@Pradumnasaraf Pradumnasaraf merged commit 568d4ac into EddieHubCommunity:main Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lakshay Tyagi
3 participants
@imlakshay08 @Pradumnasaraf @Panquesito7