-
-
Notifications
You must be signed in to change notification settings - Fork 879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@starlightknown Thanks, ma'am. |
data.json
Outdated
@@ -965,4 +965,10 @@ | |||
"imageUrl": "https://user-images.githubusercontent.com/49101362/120364787-7c501880-c2c2-11eb-8f18-0f0ef10c4439.png", | |||
"issueNumber": 539 | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
}, |
there is a comma missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! changed now #545
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn't contain your entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. For this issue you don't have to make a new Pull Request. I think it also wouldn't working this way 🤔 .
You can adjust the issues in this pull request in this branch https://github.com/skjha1/awesome-github-profiles/tree/patch-1 if you create another branch this will open a new PR which is not connected to this one.
So what to do now :)
You can add the missing comma in the patch-1 branch of your fork or you can simply commit the suggestion here in the PR by hitting the "Commit Suggestion" Button above.
Both ways will add a commit into this Pull Request and then I think we are free to go to merge it :)
If there are some more questions please let us know 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn't contain your entry
Fast as always :D
Thanks for resolving @skjha1 |
I was trying to understand in between it merged, Wow it's done!! New to PR, thanks a lot @schmelto @starlightknown |
resolve #542