Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

add skjha1 #543

Merged
merged 2 commits into from
Jun 2, 2021
Merged

add skjha1 #543

merged 2 commits into from
Jun 2, 2021

Conversation

skjha1
Copy link
Member

@skjha1 skjha1 commented Jun 2, 2021

resolve #542

Copy link
Member

@starlightknown starlightknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skjha1
Copy link
Member Author

skjha1 commented Jun 2, 2021

@starlightknown Thanks, ma'am.

data.json Outdated
@@ -965,4 +965,10 @@
"imageUrl": "https://user-images.githubusercontent.com/49101362/120364787-7c501880-c2c2-11eb-8f18-0f0ef10c4439.png",
"issueNumber": 539
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},

there is a comma missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! changed now #545

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't contain your entry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. For this issue you don't have to make a new Pull Request. I think it also wouldn't working this way 🤔 .

You can adjust the issues in this pull request in this branch https://github.com/skjha1/awesome-github-profiles/tree/patch-1 if you create another branch this will open a new PR which is not connected to this one.

So what to do now :)

You can add the missing comma in the patch-1 branch of your fork or you can simply commit the suggestion here in the PR by hitting the "Commit Suggestion" Button above.
image

Both ways will add a commit into this Pull Request and then I think we are free to go to merge it :)

If there are some more questions please let us know 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't contain your entry

Fast as always :D

@schmelto schmelto merged commit c15cbff into EddieHubCommunity:main Jun 2, 2021
@schmelto
Copy link
Contributor

schmelto commented Jun 2, 2021

Thanks for resolving @skjha1

@skjha1
Copy link
Member Author

skjha1 commented Jun 2, 2021

I was trying to understand in between it merged, Wow it's done!! New to PR, thanks a lot @schmelto @starlightknown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shivendra K Jha
3 participants