Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

Add motasimmakki #633

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Add motasimmakki #633

merged 4 commits into from
Aug 2, 2021

Conversation

motasimmakki
Copy link
Member

resolve #631

data.json Outdated Show resolved Hide resolved
Copy link
Member

@rakesh0x7 rakesh0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update with requested changes

data.json Outdated
@@ -1217,4 +1217,10 @@
"imageUrl": "https://user-images.githubusercontent.com/54446880/127509715-b594b68d-4703-4bc2-aed5-1172d7df6a5c.png",
"issueNumber": 627
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @deephunt3r mentioned here is a comma missing

Co-authored-by: Rakesh <60481830+deephunt3r@users.noreply.github.com>
Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this can be merged now @schmelto

@motasimmakki
Copy link
Member Author

LGTM, I think this can be merged now @schmelto

Sounds good ✌🏼

Copy link
Member

@rakesh0x7 rakesh0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thanks for the contribution 🎊

@NS007-dev
Copy link
Member

Just realised that there is conflicts that need resolving

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@motasimmakki
Copy link
Member Author

LGTM.

great ✨

data.json Show resolved Hide resolved
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
@motasimmakki motasimmakki requested a review from schmelto August 2, 2021 11:13
Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmelto schmelto merged commit c107288 into EddieHubCommunity:main Aug 2, 2021
@schmelto
Copy link
Contributor

schmelto commented Aug 2, 2021

Thanks for your contribution 🚀
@CodingSpecies @deephunt3r thanks for reviewing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motasim
4 participants