This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add ahamedbasha-n * add ahamedbasha-n Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
* anaskhan28 resolve #666 * Update data.json * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Update data.json * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Update data.json Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
* New profile add by Mohammad Shakib * added new profile by Shakib * Update data.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update data.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Mohammad Shakib <imoshakib@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
* Update data.json * Update data.json * Update data.json * Update data.json Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
* Komal7209 Issue number 1 * Update data.json * Updated data to last * issue Number updated issue number updated where github profile screenshot is inserted * data.json formatted * Apply suggestions from code review Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com> * Updated * space removed at end in data.json * Update data.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
* fix: bracets * Updating the README! Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update data.json * Update data.json * Update data.json
* fix: prettier issue * fix: prettier issue
* Added web link, badges * removed space * Update README.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update README.md Co-authored-by: David Leal <halfpacho@gmail.com> * Removed link Co-authored-by: David Leal <halfpacho@gmail.com>
* Create SparkScratch-P.json * Update _config.yml * Update _config.yml
* Create IAMSKJha.json * Update IAMSKJha.json Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
yep it is the |
So we have to make regular PRs to deploy? 🤨 |
* Create Lovakush.json Add profile details in Lovakush.json * Rename Lovakusj.json To Lovakush.json Rename Json file
What if we just set |
We could do that approach too. Ultimately I defer to Eddie on that. |
Can't we just write a GH Action that pushes that to the gh-pages branch? Isn't that simpler |
There are a lot of different approaches we can take. 🙂 |
Just putting this in, for further convo, #985 |
* Create sun0225SUN.json * Update sun0225SUN.json * Update sun0225SUN.json * Update sun0225SUN.json Co-authored-by: David Leal <halfpacho@gmail.com>
* Create binitrajshah7.json * Update profiles/binitrajshah7.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
gptkrsh
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but when can merge this?
Here goes nothing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eddiejaoude I don't see any automation on the repo. Can you confirm we don't have a different deployment approach?