Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Google+ login using web browser is rejected on the App Store. #37

Closed
calvingferrando opened this issue Jan 16, 2015 · 54 comments
Closed

Comments

@calvingferrando
Copy link

Reasons from App Strore:
We found the following issues with the user interface of your app:

The app opens a web page in mobile Safari for logging into Google+, then returns the user to the app. The user should be able to log in without opening Safari first.


The plugin is fine and working but didn't passed app standard using a web page. If user already installed the Google+ app then the authentication is on the app which is good otherwise it will open a web browser to do the authentication. To solve this one is we need to wrap it inside inappbrowser.

@bau720123
Copy link

agree !!

@MarcGodard
Copy link

We could also add a "Has google plug app" flag so we can offer alternative logins if the google plus app doesn't exist.

@bengtweisse
Copy link

But seriously that is not a point to reject an app?!
The reason sounds more like a "suggestion".

Has somebody additionally to the social login an ordinary one?
Like entering mail and password to login?
Does this problem exists there too?

@mcherubin
Copy link

Hello! I've the same problem. Do you solve the problem?

Thanks

@danicastanos
Copy link

Same problem here! Apple is rejecting my App because of this:

  • Upon launching the app, a web page in mobile Safari opens for logging in to google plus, then returns the user to the app. The user should be able to log in without opening Safari first (Ex. in a webview within the app)

Any thoughts or workarounds?

@avivais
Copy link

avivais commented Mar 5, 2015

Same here. Just got rejected for the same reason, as stated by the review team:
"In order for the app to be reconsidered for the App Store, it would be appropriate to ensure that Google+ users can authenticate from within the app."

I guess that no one here was able to resolve yet.

@EddyVerbruggen
Copy link
Owner

Oh boy, this is a shame. Sorry to hear this guys.

I will look into this today.

@avivais
Copy link

avivais commented Mar 5, 2015

@EddyVerbruggen thanks!

@danicastanos
Copy link

Thaaaaaanks!!!

Sent from my iPhone

On 5/3/2015, at 16:16, Eddy Verbruggen notifications@github.com wrote:

Oh boy, this is a shame. Sorry to hear this guys.

I will look into this today.


Reply to this email directly or view it on GitHub.

@EddyVerbruggen
Copy link
Owner

Hey guys, I found this issue where Google seems a bit disappointed with Apple reviewers not allowing the Safari OAuth flow (where they accept it for Facebook).

I think the quickest way to fix this is by adding a check to your app which confirms the native app can be used so the redirect won't happen. To this end I just added the isAvailable function to release 1.1.0.

If the new method returns true you can safely show a 'Sign in with Google+' button.

@avivais
Copy link

avivais commented Mar 5, 2015

Thanks for the workaround @EddyVerbruggen.

Say, what about what using inappbrowser for users without G+ app? Is that an option?

@EddyVerbruggen
Copy link
Owner

Unfortunately InAppBrowser is not a pluggable option because the Safari fallback is triggered from native code. There are ways to intercept the native URL launch and launch your own webview (much like the InAppBrowser plugin), but it's considered a hack by Google if you read this discussion.

So technically that's possible but requiring the G+ app on the iOS device is considered the best way to do it according to those two tech giants.

@bengtweisse
Copy link

@EddyVerbruggen

Do i run in the same Problem when there are other auth merhods in my app linke facebook or custom normal login at my Backend?

So Google is only one signin method?

Greetz and thanks for your work!

@EddyVerbruggen
Copy link
Owner

Yes, Apple will still likely reject your app. You better check G+ availability beforehand.

@do-web
Copy link

do-web commented Mar 13, 2015

@EddyVerbruggen
Copy link
Owner

@do-web that's the thing I referred to above when I said "but it's considered a hack by Google if you read this discussion."

@do-web
Copy link

do-web commented Mar 13, 2015

With the check "isAvailable" it will be approved in app store? so if i hide the googeplus login if gplus app is not available?

@EddyVerbruggen
Copy link
Owner

Correct, that's what folks are saying in that thread I mentioned.

@alxpereira
Copy link

Hey,
Just being rejected for that ! Thanks for the isAvailable, will try a new submit.
Suggestion : put an /!\ IMPORTANT warning on that in your Readme :)

@EddyVerbruggen
Copy link
Owner

Please send a PR

@johnfargo
Copy link

Hello! At Google I/O today, we released a new version of the Sign In library for iOS that includes several updates relevant to this thread and project.

Google Sign In SDK 2.0 is documented on our new dev site: https://developers.google.com/identity/sign-in/ios

Updates:

  1. New (but familiar) API surface, focusing on Google accounts. Google+ scopes still supported but not required.
  2. Support for Sign In completion through numerous Google apps, not just Google+. As of today, YouTube and the Google app include support in addition to G+. Several more are on the way.
  3. Native support for Sign In via WebView when no Sign In app is present. We hope this will stem the issue of app rejections discussed here.
  4. Button branding based on requested scopes. If plus.*, then red Google+. Otherwise, blue Google.
  5. Programmatically drawn button supporting flexible height/width.
  6. New packaging, based on Cocoapods. Google announced today that it is adopting this standard across as many APIs as we can.
  7. Packaged separately from the Google+ SDK for smaller code size.
  8. Canonical method "checkGoogleSignInAppInstalled" returning whether a Sign In app is installed for "direct" (non-WebView) sign in.

We'd love to hear your experience with the new SDK, and encourage everyone (including those using G+ APIs) to upgrade.

In particular, @EddyVerbruggen -- I'd love to see this plugin updated to use the new API. It would be great to change the implementation of isAvailable to "return true"!

@EddyVerbruggen
Copy link
Owner

@johnfargo Thanks John, that SDK and site look awesome, I will definitely consider switching the iOS implementation.

@quedicesebas
Copy link

@johnfargo maybe in isAvailable will call checkGoogleSignInAppInstalled. From the readme of this plugin I can asume that this plugin only works for sign in with google plus. I think that if @EddyVerbruggen switch to Google Sign In SDK (I hope so), the plugin should be called cordova-plugin-googlesingnin or something like that.

@zphingphong
Copy link
Collaborator

@EddyVerbruggen First, I'd like to thank you for making this great plugin. I don't want to sound demanding or anything, but Google Sign In SDK 2.0 would really be appreciated. The isAvailable function is a good workaround to get the app approved, but that pretty much prevent most iOS users from signing in to the app using Google+. I have never seen a single iOS users, who has G+ installed.

@johnfargo
Copy link

SDK 2.0 has isAvailable, but what's more, has WebView-based Sign In,
allowing use of Google accounts without the G+ app installed. It's also
worth noting that additional apps host Google Sign In now as well, in
particular YouTube and the Google search app.

On Sat, Jul 4, 2015 at 11:58 PM Pan K. notifications@github.com wrote:

@EddyVerbruggen https://github.com/EddyVerbruggen First, I'd like to
thank you for making this great plugin. I don't want to sound demanding or
anything, but Google Sign In SDK 2.0 would really be appreciated. The
isAvailable function is a good workaround to get the app approved, but that
pretty much prevent most iOS users from signing in to the app using
Google+. I have never seen a single iOS users, who has G+ installed.


Reply to this email directly or view it on GitHub
#37 (comment)
.

@zphingphong
Copy link
Collaborator

@johnfargo I'm not sure what you meant by "additional apps host Google Sign In now as well, in
particular YouTube and the Google search app", but I have YouTube installed on my phone, and G+ sign in still redirects me to Safari.

@johnfargo
Copy link

@pan, have you updated your app to the Google Sign In SDK?
https://developers.google.com/identity/sign-in/ios

On Mon, Jul 6, 2015 at 12:01 PM Pan K. notifications@github.com wrote:

@johnfargo https://github.com/johnfargo I'm not sure what you meant by
"additional apps host Google Sign In now as well, in
particular YouTube and the Google search app", but I have YouTube
installed on my phone, and G+ sign in still redirects me to Safari.


Reply to this email directly or view it on GitHub
#37 (comment)
.

@zphingphong
Copy link
Collaborator

@johnfargo Thank you for your suggestion. As far as I understand, I have to make change to iOS native code, which I don't have problem doing. But we're talking about this Phonegap plugin, which wraps around the native code. That's why I mentioned @EddyVerbruggen at first.

@johnfargo
Copy link

Indeed, that makes sense. The plugin does need to update to take advantage
of the changes we've made to support WebView-based Sign In, thus avoiding
app rejection issues.

On Mon, Jul 6, 2015 at 1:29 PM Pan K. notifications@github.com wrote:

@johnfargo https://github.com/johnfargo Thank you for your suggestion.
As far as I understand, I have to make change to iOS native code, which I
don't have problem doing. But we're talking about this Phonegap plugin,
which wraps around the native code. That's why I mentioned @EddyVerbruggen
https://github.com/EddyVerbruggen at first.


Reply to this email directly or view it on GitHub
#37 (comment)
.

@EddyVerbruggen
Copy link
Owner

@zphingphong I'd love to do it soon, it's just that this plugin is pure hobby which I love to work on but I'm a liiiiitle short on time these days. Rest assured I intend to upgrade it.

@zphingphong
Copy link
Collaborator

@EddyVerbruggen I understand. Could I be of any help? If you like, add me as a collaborator, and I'll try my best to update the plugin. Of course, that's only if you're comfortable.

@EddyVerbruggen
Copy link
Owner

Hi @zphingphong that would be very welcome indeed. You've been added.

Please try and keep the JS API stable unless you have absolutely no other choice. Then still, adding a new method next to the old ones is preferred.

@zphingphong
Copy link
Collaborator

Hi @EddyVerbruggen ,

I refactored iOS to use Google Sign-In SDK. I commented out the old methods, in case we need it back. Could you please maybe do a code review and publish it to pgb or plugins.cordova.io? I'll update README sometimes next week.

Thanks!

@mhcarneiro
Copy link

@zphingphong just updated my app with the new code but the fallback is still being handled by safari, which won't avoid app rejection. Might I be missing something? No changes needed in the JS side, right?

@zphingphong
Copy link
Collaborator

@mhcarneiro How did you upgrade your app with the new code, since we haven't publish this plugin yet?

@mhcarneiro
Copy link

@zphingphong Hmmm, the code is definitely different, with a lot of mentions to the Google Sign In SDK. Weird. I removed the previous plugin by executing cordova plugin rm nl.x-services.plugins.googleplus and then cordova plugin add nl.x-services.plugins.googleplus. It took me a while to install Google Sign In SDK dependencies, but the code now compiles and runs, although nothing different happens. I've checked and this code includes the files listed as changed 4 days ago in the repository. What do you mean when you say published?

@wongjoh
Copy link

wongjoh commented Aug 1, 2015

@zphingphong @EddyVerbruggen Can you guys please review and publish the plugin to pgb/npm/plugins.cordova.io soon? I assume that is the only way we can use the latest for submission to PhoneGap Build, right? Thanks

@EddyVerbruggen
Copy link
Owner

Hi @zphingphong I'm back from a little break and will review the changes during the next few days.

@wongjoh Yes, you'll need it to be in the cordova plugins registry or npm indeed. Once the review is finished I will publish an update to npm.

@mhcarneiro Do you have YouTube installed? Reading @johnfargo correctly that app should be able to handle sign-in as well. I'll be checking it myself soon.

@EddyVerbruggen
Copy link
Owner

4.0.0 is on npm, enjoy!

Please see the readme for install instructions.

@sreeram780
Copy link

Hi I got so same problem Any solution please mail me sreenu.ram2@gmail.com

Thanks in Advance

@alxpereira
Copy link

Hi @sreeram780
Just hide the G+ button if the user hasn't installed G+ app on his iPhone.
You can detect this easily.

@iyussupov
Copy link

Hi! im using isAvailable function but it always returns true. My example
$ionicPlatform.ready(function() {
window.plugins.googleplus.isAvailable(
function (available) {
$scope.isGoogleAvailable = available;
}
);

});
any solution? Thanks!

@johnfargo
Copy link

All,

So long as you're using Google Sign In API 2.3 or above, there should no
longer be risk of rejection from Apple, as this SDK uses the Apple-approved
SFSafariViewController mechanism to achieve Sign In and OAuth consent.

Note as well that this release completely obviates the need to use
GooglePlus.framework. @eddy, our documentation has changed (and simplified
a bit) as well. Sign In homepages are Android (
https://developers.google.com/identity/sign-in/android/) and iOS (
https://developers.google.com/identity/sign-in/ios/). In particular, enabling
the Google+ API is no longer required if you don't use Google+ APIs
(instead using basic Sign In with name, email, and profile URL).

On a broader level, I suppose the plugin overall could be renamed, though
that's a much more invasive change. Sign In with Google+ account and
credentials still works as it always did, so dropping the + is only an
option.

On Tue, Nov 17, 2015 at 2:28 AM iyussupov notifications@github.com wrote:

Hi! im using isAvailable function but it always returns true. My example
$ionicPlatform.ready(function() {
window.plugins.googleplus.isAvailable(
function (available) {
$scope.isGoogleAvailable = available;
}
);

});
any solution? Thanks!


Reply to this email directly or view it on GitHub
#37 (comment)
.

@visormatt
Copy link

@johnfargo I was hoping you could clarify something. When the app is not available, the current Web View flow that I am see happen does not allow the user to back out or "cancel" trying to log in. Which then leaves the user w/o a way to get back to the app, is this correct?

@PrakashT
Copy link

Can you check this link,
http://technogerms.com/login-with-google-using-oauth-2-0-for-ios-xcode-objective-c/
I think it will solve your problems

@celwell
Copy link

celwell commented Nov 30, 2015

I'm noticing that even with the Google+ app installed on iOS, this plugin 4.0.6 on npm is favoring use of the webview. I can't get it to use Google+ app to login at all anymore. If Apple will approve the use of the webview even when the Google+ app is available, then this is good enough. But I worry that they will reject it.

@patternott
Copy link

@celwell I'm experience the same behaviour. No matter what I try it doesn't want to use the Google+ app anymore

@visormatt
Copy link

@celwell @patternott I've just had an app that was succesfully approved using the new setup. Mine too no longer will Auth using the application, however as noted by @johnfargo this appears to be perfectly acceptable now.

@celwell
Copy link

celwell commented Dec 1, 2015

@visormatt Great to hear that it is acceptable. I hope still that this could be improved since the inappbrowser doesn't save login sessions: every time you have to type in your username and password. Oh well, I hope I pass Apple review.

@visormatt
Copy link

@celwell if you all up to date and also using the SafariWebView it does seem to save the session as long as you have not called logout. I wish I could point you to my app for an example but not realeasing it until the weekend. However a quick check, If you have not added https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller it would be worth giving that a add, it's a much safer and faster anyhow.

shinyMetilda pushed a commit to shinyMetilda/cordova-plugin-googleplus that referenced this issue Mar 22, 2016
@mahmoudkhalafallah
Copy link

@EddyVerbruggen i'm using version 5.0.2 of the plugin and still have the same issue, The app opens a web page in mobile Safari for logging into Google+, then returns the user to the app.

@sammugg
Copy link

sammugg commented Sep 20, 2016

@mahmoudkhalafallah It's supposed to do that! The Google Sign In SDK makes use of the SafariViewController to log the user. Think of it as a sign-in pop-up.

@sammugg
Copy link

sammugg commented Sep 20, 2016

Also, that is no longer grounds for rejection from the app store.

@mahmoudkhalafallah
Copy link

@sammuggPS Thanks, my app has been accepted.

pwbs pushed a commit to pwbs/cordova-plugin-googleplus that referenced this issue Jun 27, 2017
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 7 commits.
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 6 commits.
# This is the 1st commit message:
# This is a combination of 10 commits.
# This is the 1st commit message:
Finished implementation

# The commit message EddyVerbruggen#2 will be skipped:

#	Attempt at some decent documentation

# The commit message EddyVerbruggen#3 will be skipped:

#	Attempt at some decent documentation

# The commit message EddyVerbruggen#4 will be skipped:

#	Added iOS screenshots

# The commit message EddyVerbruggen#5 will be skipped:

#	cleanup

# The commit message EddyVerbruggen#6 will be skipped:

#	Added a permission for Android preventing a crash on some devices

# The commit message EddyVerbruggen#7 will be skipped:

#	Cleanup

# The commit message EddyVerbruggen#8 will be skipped:

#	iOSApiKey is for iOS, not for Android :)

# The commit message EddyVerbruggen#9 will be skipped:

#	EddyVerbruggen#3 redirect url not handled when redirected from Google+ app on iOS

# The commit message EddyVerbruggen#10 will be skipped:

#	EddyVerbruggen#6 ADD Birthday and AgeRange

# The commit message EddyVerbruggen#1 will be skipped:

#	EddyVerbruggen#6 ADD Birthday and AgeRange (wasn't really happy with the PR, so I changed it a bit and added iOS support). Thanks for the help!

# The commit message EddyVerbruggen#2 will be skipped:

#	EddyVerbruggen#6 addtional checks on Android

# The commit message EddyVerbruggen#3 will be skipped:

#	Add userId property to let developer to get Google user ID for business logic.

# The commit message EddyVerbruggen#4 will be skipped:

#	EddyVerbruggen#7, needed to manually merge

# The commit message EddyVerbruggen#5 will be skipped:

#	EddyVerbruggen#7, needed additional flag

# The commit message EddyVerbruggen#6 will be skipped:

#	Missing dependency for iOS 8 SDK

# The commit message EddyVerbruggen#7 will be skipped:

#	Android - play services jar fixed version

# The commit message EddyVerbruggen#8 will be skipped:

#	Android playservices updated to 21

# The commit message EddyVerbruggen#9 will be skipped:

#	Update README.md
#
#	Fix typo. I believe this is for iOS only right now and not Android yet if I'm not mistaken.

# The commit message EddyVerbruggen#10 will be skipped:

#	A note about Android config

# The commit message EddyVerbruggen#1 will be skipped:

#	EddyVerbruggen#15 added troubleshooting section

# The commit message EddyVerbruggen#2 will be skipped:

#	Adding idToken to Android
#
#	Based on this gist [1] I'm adding support for getting the auth oauth2 token
#	that Google generates after the user accepts the login.
#
#	[1] https://gist.github.com/ianbarber/5170508

# The commit message EddyVerbruggen#3 will be skipped:

#	Introducing idToken and oauthToken
#
#	Allow the user to configure the service so any of the 3 possibles can be reached
#	when the user passes webApiKey in the credentials dictionary will get a JWT token
#	id, if androidApiKey is set in the credentials then an off-line capable oauth2
#	token bearer will be generated in the oauthToken value, while if no argument is
#	set a simple oauth2 token will get generated.

# The commit message EddyVerbruggen#4 will be skipped:

#	Adding extra necessary permissions

# The commit message EddyVerbruggen#5 will be skipped:

#	EddyVerbruggen#12 oauthToken for iOS

# The commit message EddyVerbruggen#6 will be skipped:

#	EddyVerbruggen#22 User-cancelled login on iOS - Neither the success nor error callbacks are called

# The commit message EddyVerbruggen#7 will be skipped:

#	EddyVerbruggen#26 Preparing submission to plugins.cordova.io

# The commit message EddyVerbruggen#8 will be skipped:

#	Prep plugin registry release (as tarball, to circumvent an npm symlink issue)

# The commit message EddyVerbruggen#9 will be skipped:

#	Added a warning about the current state of the plugman publish command

# The commit message EddyVerbruggen#10 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#1 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#2 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#3 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#4 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#5 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#6 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#7 will be skipped:

#	Removing the symlinks from iOS libs to be plugman (npm) publish compliant

# The commit message EddyVerbruggen#8 will be skipped:

#	EddyVerbruggen#37 Google+ login using web browser is rejected on the App Store.

# The commit message EddyVerbruggen#9 will be skipped:

#	From Cordova 4 setActivityResultCallback is on CordovaInterfaceImpl

# The commit message EddyVerbruggen#10 will be skipped:

#	Not importing android-support-v4

# The commit message EddyVerbruggen#1 will be skipped:

#	EddyVerbruggen#45 login and trySilendLogin now return userdata on Android

# The commit message EddyVerbruggen#2 will be skipped:

#	Update plugin.xml

# The commit message EddyVerbruggen#3 will be skipped:

#	Update plugin.xml

# The commit message EddyVerbruggen#4 will be skipped:

#	EddyVerbruggen#56 new playservices version

# The commit message EddyVerbruggen#5 will be skipped:

#	npm

# The commit message EddyVerbruggen#6 will be skipped:

#	or not to npm..

# The commit message EddyVerbruggen#7 will be skipped:

#	replace deprecated dependency plugin

# The commit message EddyVerbruggen#8 will be skipped:

#	New ID, published to npm

# The commit message EddyVerbruggen#9 will be skipped:

#	New ID, published to npm

# The commit message EddyVerbruggen#10 will be skipped:

#	PGB note

# The commit message EddyVerbruggen#1 will be skipped:

#	Update dependencies to gradle format to fix EddyVerbruggen#64

# The commit message EddyVerbruggen#2 will be skipped:

#	bump

# The commit message EddyVerbruggen#3 will be skipped:

#	Switch to Google Sign-In SDK for iOS
#
#	This should fix Apple rejection from popping up Safari.
#	Will update README soon.
#	Update version to 3.0.0.

# The commit message EddyVerbruggen#4 will be skipped:

#	Allowed scope to be passed into signin

# The commit message EddyVerbruggen#5 will be skipped:

#	Attempt to fix offline screen

# The commit message EddyVerbruggen#6 will be skipped:

#	Cleanup for google plus connection with scopes and offline access

# The commit message EddyVerbruggen#7 will be skipped:

#	Fixed REVERSED_CLIENT_ID variable

# The commit message EddyVerbruggen#8 will be skipped:

#	Invalid quotes (according to my IDE)

# The commit message EddyVerbruggen#9 will be skipped:

#	Made ios use scopes

# The commit message EddyVerbruggen#10 will be skipped:

#	Added server auth code logic for ios

# The commit message EddyVerbruggen#1 will be skipped:

#	Made server auth code not throw a null reference

# The commit message EddyVerbruggen#2 will be skipped:

#	Plugin update to 4.0.0:
#	- Changed the ID to cordova-plugin-googleplus (again)
#	- Wider Android dependent fwk compatibility
#	- Documented scopes feature
#	- Removed the need for the iosApiKey

# The commit message EddyVerbruggen#3 will be skipped:

#	Fixed npm reference in doc

# The commit message EddyVerbruggen#4 will be skipped:

#	EddyVerbruggen#95 Crash when using isAvailable method before login

# The commit message EddyVerbruggen#5 will be skipped:

#	access_token fix for iOS
#
#	The access_token will now be returned as: accessToken

# The commit message EddyVerbruggen#6 will be skipped:

#	* generate both oauthToken and idToken

# The commit message EddyVerbruggen#7 will be skipped:

#	Added an "offline" parameter to enable getting a server auth token even without androidApiKey.

# The commit message EddyVerbruggen#8 will be skipped:

#	Added info to README about the API key for serverClientId.

# The commit message EddyVerbruggen#9 will be skipped:

#	Google decided to change a link without adding a nice redirect

# The commit message EddyVerbruggen#10 will be skipped:

#	Enabled getting serverAuthCode when the webApiKey param is set.

# The commit message EddyVerbruggen#2 will be skipped:

#	EddyVerbruggen#108 Added an option to generate access token for offline access on Android

# The commit message EddyVerbruggen#3 will be skipped:

#	EddyVerbruggen#82 Google Plus window not loading!
#	EddyVerbruggen#113 Not getting user extras (e.g. imageUrl) in callback object. Re-added imageUrl for iOS

# The commit message EddyVerbruggen#4 will be skipped:

#	Android: Ensure a new one time token on each login
#
#	When using the androidApiKey parameter a short-lived one time token
#	is generated, which can then be passed to the server where it can be
#	exchanged for a proper access and refresh token. Since all tokens get
#	cached by GoogleAuthUtil logging in a second time will cause the token
#	to be invalid if it was used before or some time has passed.

# The commit message EddyVerbruggen#5 will be skipped:

#	EddyVerbruggen#118 App Crash

# The commit message EddyVerbruggen#6 will be skipped:

#	EddyVerbruggen#147 Android fwk tags

# The commit message EddyVerbruggen#7 will be skipped:

#	Android 6.0
#
#	Added call to request permission

# The commit message EddyVerbruggen#8 will be skipped:

#	EddyVerbruggen#149 Android 6.0

# The commit message EddyVerbruggen#9 will be skipped:

#	IOS Build fails with compilation errors EddyVerbruggen#150

# The commit message EddyVerbruggen#10 will be skipped:

#	IOS Build fails with compilation errors EddyVerbruggen#150

# The commit message EddyVerbruggen#1 will be skipped:

#	Android: Gets a new offline token on each login
#
#	Based on EddyVerbruggen#119
#	I tested this on an app I'm working where every authentication attempt returned the same invalid token. After applying this change, the authentication works fine each time.

# The commit message EddyVerbruggen#2 will be skipped:

#	Get refreshToken on iOS sign in
#
#	The refresh token is a useful token for third party apps, to refresh the access token and keep users logged in.

# The commit message EddyVerbruggen#3 will be skipped:

#	Update README.md

# The commit message EddyVerbruggen#4 will be skipped:

#	Updated Google Sign-In iOS SDK to 2.4.0

# The commit message EddyVerbruggen#5 will be skipped:

#	Enabled GoogleOpenSource.framework explicitely

# The commit message EddyVerbruggen#6 will be skipped:

#	EddyVerbruggen#153 Ios updated google framework

# The commit message EddyVerbruggen#2 will be skipped:

#	EddyVerbruggen#168 IOS Build failure with this plugin

# The commit message EddyVerbruggen#2 will be skipped:

#	Added a few npm keywords

# The commit message EddyVerbruggen#3 will be skipped:

#	Update GooglePlus.java
#
#	Fix for app crash on android 6

# The commit message EddyVerbruggen#2 will be skipped:

#	A note about failing Android builds

# The commit message EddyVerbruggen#3 will be skipped:

#	Adding a link to how to use keytool

# The commit message EddyVerbruggen#2 will be skipped:

#	Update README.md

# The commit message EddyVerbruggen#3 will be skipped:

#	Update README.md

# The commit message EddyVerbruggen#4 will be skipped:

#	Google success login redirects to google.com issue fixed

# The commit message EddyVerbruggen#5 will be skipped:

#	iOS readme updated to include latest Google SDK changes

# The commit message EddyVerbruggen#6 will be skipped:

#	Update README.md

# The commit message EddyVerbruggen#7 will be skipped:

#	Update README.md

# The commit message EddyVerbruggen#2 will be skipped:

#	Remove OpenSource and Plus libraries.

# The commit message EddyVerbruggen#2 will be skipped:

#	ignoring some more files

# The commit message EddyVerbruggen#2 will be skipped:

#	Google SignIn framework bump

# The commit message EddyVerbruggen#2 will be skipped:

#	ignore

# The commit message EddyVerbruggen#2 will be skipped:

#	testing sth

# The commit message EddyVerbruggen#3 will be skipped:

#	testing sth

# The commit message EddyVerbruggen#2 will be skipped:

#	new demos for firebase and ionic2+firebase

# The commit message EddyVerbruggen#3 will be skipped:

#	typo fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests