Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom lang path #32

Merged
merged 4 commits into from
Jan 18, 2017

Conversation

lukashlobil
Copy link
Contributor

This shoul do it - sorry I haven't really worked on open source before, had trouble forcing Webstorm to adhere to your formatting standards (that's why there are so many commits)

On another note - I checked how iOS does it - you need to set CFBundleDevelopmentRegion in your Info.Plist, which seems like out of scope of this plugin, maybe just add the information to readme?

@rborn
Copy link
Collaborator

rborn commented Jan 18, 2017

Great, thank you 👍
Yes, I'll use CFBundleDevelopmentRegion and add it to the iOS part, hopefully this week and then I'll publish on npm (and change the readme if needed).

Thanks again for your help 😄

@rborn rborn merged commit afae804 into EddyVerbruggen:custom_lang_path Jan 18, 2017
@rborn rborn mentioned this pull request Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants