Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

IOS firebase to JSON not converting numbers with NSDecimalNumber subclass #365

Closed
jorgelcf opened this issue May 5, 2017 · 3 comments
Closed

IOS firebase to JSON not converting numbers with NSDecimalNumber subclass #365

jorgelcf opened this issue May 5, 2017 · 3 comments
Assignees
@EddyVerbruggen
Labels
bug iOS
Milestone
4.0.0

Comments

@jorgelcf
Copy link

jorgelcf commented May 5, 2017

Hi,

I was not receiving the keys which values were numbers in firebase due to the fact that the class received from the getClass method call is NSDecimalNumber.

I resolved the issue by adding 'NSDecimalNumber' as an option to the switch of the funtion 'firebase.toJsObject' (line 354).
@EddyVerbruggen
Copy link
Owner

Cool. Are you up for a little PR perhaps?

@EddyVerbruggen EddyVerbruggen self-assigned this Jun 20, 2017
@EddyVerbruggen EddyVerbruggen added this to the 4.0.0 milestone Jun 20, 2017
@EddyVerbruggen
Copy link
Owner

Added this to 4.0.0.

EddyVerbruggen added a commit that referenced this issue Jun 20, 2017
@EddyVerbruggen
IOS firebase to JSON not converting numbers with NSDecimalNumber subc…
9a9362c 
…lass #365
@EddyVerbruggen
Copy link
Owner

Also added a fallback and warning for any other possibly missing types.

@EddyVerbruggen EddyVerbruggen mentioned this issue Jun 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EddyVerbruggen EddyVerbruggen

Labels
bug iOS
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@EddyVerbruggen @jorgelcf