Merge pull request #5372 from EdgeApp/jon/analytics/swap-assets

Add `isBuiltinAsset` to `Exchange_Shift_Success`
EdgeApp · Nov 26, 2024 · 89d5c51 · 89d5c51
2 parents ce37529 + 78edce3
commit 89d5c51
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- added: `isBuiltInAsset` param for 'Exchange_Shift_Success' tracking event
+
 ## 4.17.2
 
 - fixed: (Zcash/Pirate) Fixed android build issues

diff --git a/src/components/scenes/SwapConfirmationScene.tsx b/src/components/scenes/SwapConfirmationScene.tsx
@@ -162,7 +162,7 @@ export const SwapConfirmationScene = (props: Props) => {
     const { fromDisplayAmount, fee, fromFiat, fromTotalFiat, toDisplayAmount, toFiat } = await dispatch(getSwapInfo(selectedQuote))
     const { isEstimate, fromNativeAmount, toNativeAmount, networkFee, pluginId, expirationDate, request } = selectedQuote
     // Both fromCurrencyCode and toCurrencyCode will exist, since we set them:
-    const { toWallet, toTokenId } = request
+    const { toWallet, toTokenId, fromWallet, fromTokenId } = request
     try {
       dispatch(logEvent('Exchange_Shift_Start'))
       const result: EdgeSwapResult = await selectedQuote.approve()
@@ -199,12 +199,20 @@ export const SwapConfirmationScene = (props: Props) => {
       dispatch(
         logEvent('Exchange_Shift_Success', {
           conversionValues: {
-            conversionType: 'crypto',
-            cryptoAmount: new CryptoAmount({
+            conversionType: 'swap',
+            destAmount: new CryptoAmount({
               nativeAmount: toNativeAmount,
               tokenId: toTokenId,
               currencyConfig: toWallet.currencyConfig
             }),
+            sourceAmount: new CryptoAmount({
+              nativeAmount: fromNativeAmount,
+              tokenId: fromTokenId,
+              currencyConfig: fromWallet.currencyConfig
+            }),
+            isBuiltInAsset:
+              (toTokenId == null || toWallet.currencyConfig.builtinTokens[toTokenId] != null) &&
+              (fromTokenId == null || fromWallet.currencyConfig.builtinTokens[fromTokenId] != null),
             orderId: result.orderId,
             swapProviderId: pluginId
           }

diff --git a/src/util/tracking.ts b/src/util/tracking.ts
@@ -80,6 +80,20 @@ export interface CryptoConversionValues {
   orderId?: string
 }
 
+/**
+ * Analytics: Swap
+ */
+export interface SwapConversionValues {
+  conversionType: 'swap'
+  isBuiltInAsset: boolean
+
+  destAmount: CryptoAmount
+  sourceAmount: CryptoAmount
+
+  swapProviderId?: string
+  orderId?: string
+}
+
 /**
  * Analytics: Sell to fiat
  */
@@ -125,7 +139,7 @@ export interface TrackingValues extends LoginTrackingValues {
   surveyResponse?: string // User's answer to a survey
 
   // Conversion values
-  conversionValues?: DollarConversionValues | CryptoConversionValues | SellConversionValues | BuyConversionValues
+  conversionValues?: DollarConversionValues | CryptoConversionValues | SellConversionValues | BuyConversionValues | SwapConversionValues
 }
 
 // Set up the global Posthog analytics instance at boot
@@ -255,6 +269,21 @@ export function logEvent(event: TrackingEventName, values: TrackingValues = {}):
 
             params.dollarValue = Math.abs(Number(cryptoAmount.displayDollarValue(exchangeRates)))
 
+            if (orderId != null) params.orderId = orderId
+            if (swapProviderId != null) params.swapProviderId = swapProviderId
+          } else if (conversionType === 'swap') {
+            const { destAmount, sourceAmount, swapProviderId, orderId, isBuiltInAsset } = conversionValues
+
+            params.isBuiltInAsset = isBuiltInAsset
+
+            params.sourceCryptoAmount = Math.abs(Number(sourceAmount.exchangeAmount))
+            params.sourceCurrencyCode = sourceAmount.currencyCode
+            params.sourceDollarValue = Math.abs(Number(sourceAmount.displayDollarValue(exchangeRates)))
+
+            params.destCryptoAmount = Math.abs(Number(destAmount.exchangeAmount))
+            params.destCurrencyCode = destAmount.currencyCode
+            params.destDollarValue = Math.abs(Number(destAmount.displayDollarValue(exchangeRates)))
+
             if (orderId != null) params.orderId = orderId
             if (swapProviderId != null) params.swapProviderId = swapProviderId
           }