Changed Banxa to use API #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Banxa to use their API instead of CSV files. The banxaToken should be set to the production private key that you should have received from us on account creation. If you do not have this then speak to Jan to get this again.
I needed to add one additional module for sleep as if you are regenerating a lot of the data, then there is a chance you could hit the throttle limit so this will allow it to sleep for a period before trying again. If this does fail then it will store the date and the data it got up to and start from that point on the next run
Finally I actually push the date back by a week when it starts since some of our payments can be delayed by a few days due to over weekend processing of bank transfers hence a pending order could still go to complete after 4 days.
I will send the new banRaw.json file back to you over slack