Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sv-SE (Swedish) generation files added 🇸🇪 #41

Merged
merged 12 commits into from
Sep 8, 2022

Conversation

ulfhedlund
Copy link
Contributor

Added files for generation of Swedish standard sounds, as well as for INAV. Betaflight and Yaapu sounds are not included.
Voice used is sv-SE-SofieNeural.

@ulfhedlund ulfhedlund changed the title sv_SE sounds generation files added sv-SE sounds generation files added Sep 6, 2022
@pfeerick
Copy link
Member

pfeerick commented Sep 7, 2022

Would it be possible for you to have the "Source text" in English, i.e. as in the Japanese (ja-JP) or Chinese (zh-CN) translations. The other translation files are still the old format (i.e. really only have the destination translation format), so aren't' the best reference. The idea is that a dual language speaker can see what the original intent was, and then translate as required. And for English speakers like myself to be able to add new phases in English, ready for translation.

This will eventually be used for Crowdin translation as well, but not there yet.

@pfeerick
Copy link
Member

pfeerick commented Sep 7, 2022

I am a little pedantic about the CSV formatting (i.e. quotes) as it 1) helps with lining stuff up in code editor that has color formatting if not using a speadsheet tool to work on the files as more color is shown and 2) ensures multi-word strings don't get mangled somewhere along the way.

Don't worry if the quoting is lost if you use a spreadsheet tool or something to edit the files - it's easy enough to re-format - when I'm paying proper attention, that is! 😆

image

@ulfhedlund
Copy link
Contributor Author

Absolutely, I thought it was a bit strange to have both source text and translation in Swedish. I'll get that sorted but it will take a while since I will be travelling for a few days.

@ulfhedlund
Copy link
Contributor Author

ulfhedlund commented Sep 7, 2022

Was an easy fix so I have now added source text in English and also translations for Betaflight.
Some of the translations are more of a phonetic kind, since the translator has some quirky pronunciations (the letter D for example) and some words are really awkward to translate (e.g. angle, horizon and acro mode). But all are tested and sounds reasonably OK, I think.
Quoting also added.

@pfeerick
Copy link
Member

pfeerick commented Sep 7, 2022

Doesn't have to be perfect first time around... at least there is something we can get some ears on ;) Once the radio knows about sv-SE, that is ;) Thanks for this! :) Edit: And yes, sometimes have to use some phonetics to force the text to speech to say it right... I think there is a whole section on the Azure site about it but I've not gone near it! 😁

@pfeerick pfeerick changed the title sv-SE sounds generation files added feat: sv-SE (Swedish) generation files added 🇸🇪 Sep 8, 2022
@pfeerick pfeerick merged commit 60cd6b1 into EdgeTX:main Sep 8, 2022
@ulfhedlund ulfhedlund deleted the sv-SE_sounds branch October 3, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants