Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix minor linting issues #89

Merged

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Jan 2, 2024

I fixed a few linting issues while reading the code.

  • I used Flake8, but ignored the line too long errors.
  • I also made sure f-strings are used consistently (over a mixture of f-strings and .format()) because they're more readable and some were already used.

@pfeerick pfeerick changed the title Refactor fix minor linting issues refactor: Fix minor linting issues Jan 3, 2024
@pfeerick
Copy link
Member

pfeerick commented Jan 3, 2024

LGTM, consistency is good! :) Think I started with the older .format strings, and then moved to F strings as adding more stuff, as well as some of that would have come from the example SPX API code ...

@pfeerick pfeerick merged commit 3093192 into EdgeTX:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants