Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SE car sounds #98

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Added SE car sounds #98

merged 3 commits into from
Feb 14, 2024

Conversation

ulfhedlund
Copy link
Contributor

@ulfhedlund ulfhedlund commented Feb 10, 2024

I have added SE car sound translations but not created the actual sound files. I tried to use the Azure TTS but couldn't get it to work.
Hope this can be done when merging to main.

ulfhedlund and others added 3 commits February 10, 2024 17:13
https://github.com/EdgeTX/edgetx/blob/07e0bfa4bd77c1b49ad38f3c6f82a8b2ae15a5c7/radio/src/audio.cpp#L167

Firmware and sound pack were out of sync prior to EdgeTX/edgetx#3920 and firmware was updated to use the filename used in the sound pack since the sound pack is less likely to be updated.
@pfeerick
Copy link
Member

Thanks for this. I removed the change to the radian filename as post EdgeTX/edgetx#3920 the firmware will look for the right name. Now that I'm thinking of it, could have included just that change in 2.9.4 but too late now as it's released.

@pfeerick pfeerick merged commit fdc7acf into EdgeTX:main Feb 14, 2024
1 check passed
@ulfhedlund
Copy link
Contributor Author

ulfhedlund commented Feb 14, 2024

Me not being a programmer haven't been able to figure out how to test the pronunciation in Azure now. It seems that simple and freely available function has been removed from Azure for some reason. So some of it may sound like crap.
Edit: actually sounds OK, except for one minor spelling mistake I made.

@ulfhedlund ulfhedlund deleted the SE_car_sounds branch February 14, 2024 18:50
@pfeerick
Copy link
Member

Hm... damn... so it has... that was handy being able to generate the audio at the web page and see what it sounded like... now it looks like they want to create a "free" account... it works... but brings the hassle of getting SPX setup.

This may be another option... dunno how long it will last though. https://play.ht/text-to-speech-voices/microsoft-azure/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants