Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgui updates #123

Merged
merged 24 commits into from
Dec 7, 2023
Merged

Conversation

offer-shmuely
Copy link
Contributor

libgui: support min/max on numbers
libgui: update text offsets for 2.9
libgui: support scripts, and not just widgets

@pfeerick
Copy link
Member

pfeerick commented Dec 3, 2023

On EdgeTX 2.9, and when compared to the behaviour of the 2.9 sdcard pack version of the libgui library...

  1. The widget seems no longer able to know whether it is running in widget or fullscreen mode - i.e. it used to simply show a frame with the LibGUI name when in widget mode, and then when full screen it would show the full UI... now it tries to show part of the full UI in the widget mode.

  2. I got a refresh error when changing the value of the "Number" field - attempt to compare number with nil.

@offer-shmuely
Copy link
Contributor Author

I will check it tomorrow

@offer-shmuely
Copy link
Contributor Author

on 2.9.2 simulator, I see the following:

widget mode
image

full screen mode:
image

are you on 2.9 or nightly main?

@pfeerick
Copy link
Member

pfeerick commented Dec 5, 2023

On EdgeTX 2.9, and when compared to the behaviour of the 2.9 sdcard pack version of the libgui library...

I was referring to the change in behaviour from
image
to
image

which IMO is a major step backwards, as it would seem there is no longer widget and fullscreen modes?

And regarding the second point above... it is this the field pointed to with the arrow
image

which when you try to change the value from 0 to something else (I was using key navigation, so the roller) now causes
image

@offer-shmuely
Copy link
Contributor Author

the error, was a bug in the addition of the min/max, when they was not supplied, thanks for finding.

regarding the notification when not in app-mode,
is the following ok?

layout 1/1
image

layout 2x2
image

@pfeerick
Copy link
Member

pfeerick commented Dec 6, 2023

It'll do for now. I'll merge this once you push that change.

@offer-shmuely
Copy link
Contributor Author

I did push the change,
feel free to suggest other way to describe that the widget is not operative
in the past, it took me a while to understand that to show this widget capability, you need to move to full screen.
now it looks trivial, but on the first time it is not clear at all

@pfeerick
Copy link
Member

pfeerick commented Dec 7, 2023

Indeed. That's why I'm not pushing for it to go back to how it was before ;)

@pfeerick pfeerick merged commit f14c222 into EdgeTX:master Dec 7, 2023
2 checks passed
@offer-shmuely offer-shmuely deleted the shmuely/libgui_updates branch February 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants