Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more RGB LED lua scripts for MT12 #124

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

zyren
Copy link
Contributor

@zyren zyren commented Dec 6, 2023

I used Github Copilot and, referencing some existing Scripts, wrote some new cool LED light scripts for the MT12, hoping these scripts will be adopted.

@3djc
Copy link
Collaborator

3djc commented Dec 7, 2023

I see some comments in Chinese, could you change those to English?

@zyren
Copy link
Contributor Author

zyren commented Dec 7, 2023

I see some comments in Chinese, could you change those to English?

Oh, I forgot. Thanks for the reminder. I will change all the comments to English.

@pfeerick
Copy link
Member

These are looking great. You may want to revisit them before I merge this, as EdgeTX/edgetx#4400 has opened it up so that the full 255 range should be properly open for use, rather than capping out at 50 ;)

@zyren
Copy link
Contributor Author

zyren commented Dec 11, 2023

These are looking great. You may want to revisit them before I merge this, as EdgeTX/edgetx#4400 has opened it up so that the full 255 range should be properly open for use, rather than capping out at 50 ;)

Oh, EdgeTX/edgetx#4400 solved a major issue. Before this, I always wondered why the brightness changes of each light were so strange. I will retest and modify the Lua script to make it cooler.

…o make them more splendid.

Regarding EdgeTX/edgetx#4400, it made the brightness and RGB transitions of the lights very smooth, creating an especially splendid and stunning effect.
@pfeerick pfeerick changed the title Added new RGB LED lua scripts for MT12 Add more RGB LED lua scripts for MT12 Dec 12, 2023
@pfeerick
Copy link
Member

Yeah, I thought you would like that! 🙂 Thanks for the update, these are great!

@pfeerick pfeerick merged commit 4ca86de into EdgeTX:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants