Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horus X12S Touchscreen. Wrong function selected. #2063

Closed
1 task done
KevinFairgrieve opened this issue Jun 18, 2022 · 58 comments
Closed
1 task done

Horus X12S Touchscreen. Wrong function selected. #2063

KevinFairgrieve opened this issue Jun 18, 2022 · 58 comments
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting

Comments

@KevinFairgrieve
Copy link

KevinFairgrieve commented Jun 18, 2022

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

When selecting a menu from the eight main images. The wrong one is selected.
The screen is then locked from touch.
Going in to a menu using the rotary encoder I.E. MDL and then selecting the telemetry icon. RF set up is displayed, again touch is disabled.

Please see the video it makes it much clearer.

Expected Behavior

When the relevant item is selected it should go to that screen.

Steps To Reproduce

See Video
https://www.youtube.com/watch?v=1cRtON4a6s8

Version

Other (Please specify below)

Transmitter

FrSky X12

Anything else?

Horus X12S with touchscreen mod.
FW: edge tx-x12s
VERS: 2.8.0-nightly (c4fc11b)
Date: 2022-06-18
Time: 03:17:33
CFG: EPROM_VER

@KevinFairgrieve KevinFairgrieve added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jun 18, 2022
@raphaelcoeffic
Copy link
Member

That pretty much sounds like you mounted the touch sensor upside down.

@raphaelcoeffic
Copy link
Member

Or the touch sensor outputs the coordinates inverted.

@KevinFairgrieve
Copy link
Author

KevinFairgrieve commented Jun 19, 2022

Using the firmware from "https://github.com/wimalopaan/Electronics/tree/main/edgetx/firmware/x12s" I have had no issues, as per this video.

https://www.youtube.com/watch?v=hiQ0qBhCax8

@wimalopaan
Copy link
Contributor

Just tested witch actual main and it works as expected

@KevinFairgrieve
Copy link
Author

Just tested witch actual main and it works as expected

main?

Can you add an EN version so that I can try that?

Many thanks.

@rotorman
Copy link
Member

main means main branch of EdgeTX. For building on your own, please see: https://github.com/EdgeTX/edgetx/wiki/Building-radio-firmware-in-a-webbrowser-with-Gitpod

@wimalopaan
Copy link
Contributor

wimalopaan commented Jun 19, 2022 via email

@KevinFairgrieve
Copy link
Author

KevinFairgrieve commented Jun 19, 2022

Will try tomorrow.

Thanks again.

@pfeerick
Copy link
Member

main?

Can you add an EN version so that I can try that?

i.e. For a pre-build main you can choose the latest build from here, or use a nightly build or grab

@KevinFairgrieve
Copy link
Author

KevinFairgrieve commented Jun 20, 2022

Just use my german version to test, if you can select the functions

Will try tomorrow.

Thanks again.

Tried the DE version, still the same.

@wimalopaan
Copy link
Contributor

wimalopaan commented Jun 20, 2022 via email

@KevinFairgrieve
Copy link
Author

And I have now tried the latest "main" 3ce1aef

Still the same.

Pretty sure my screen is in the correct way, but a stripdown will show that.

@pfeerick
Copy link
Member

Check the touch screen diagnostics first ... Radio Settings -> Hardware -> Analogs (at the very bottom). If you press and hold in the middle of the screen, and then move up to the top left corner, coordinates should be near 0,0, and near 480,272 at the bottom right corner

@KevinFairgrieve
Copy link
Author

Check the touch screen diagnostics first ... Radio Settings -> Hardware -> Analogs (at the very bottom). If you press and hold in the middle of the screen, and then move up to the top left corner, coordinates should be near 0,0, and near 480,272 at the bottom right corner

So that appears to be my issue. If I move to top left the cross goes to bottom right. How to fix?

Have I wired something wrong?

@raphaelcoeffic
Copy link
Member

So that appears to be my issue. If I move to top left the cross goes to bottom right. How to fix?

Have I wired something wrong?

possibly, you should check how the sensor is oriented. Other possibility would be that it’s configuration stored inside is wrong.

@rcman45
Copy link

rcman45 commented Jun 23, 2022

si le capteur est mal monté ou si sa configuration interne est incorrecte alors pourquoi fonctionne-t’il avec la version de wimalopaan

English translation: if the sensor is incorrectly mounted or if its internal configuration is incorrect then why does it work with the version of wimalopaan

@pfeerick
Copy link
Member

Given you mention that etx_x12s_de_2.8.0_wm_touch_4.bin and etx_x12s_de_2.8.0_wm_touch_5.bin didn't work for you, but etx_x12s_en_2.8.0_wm_touch_3.bin did, it could be due to changes as the PR for this evolved - hence why internal configuration of the TP itself could be wrong / at fault. I think the early version of wimalopaan's PR may have set the rotation bit every time, rather than just when it was different to what was expected, or had some other rotation flag enabled... which may not have have been detected while it was being tested since it probably wasn't done with an as new screen (until now).

@KevinFairgrieve
Copy link
Author

I just saw that an uninverted version was available.
https://github.com/wimalopaan/Electronics/tree/main/edgetx/firmware/x12s

This has now solved my issue. I hope this will be rolled out to the full release. Currently only available as a DE version.

@pfeerick
Copy link
Member

Rather than just hope, why not ask @wimalopaan what was configured differently in that firmware build? ;)

@raphaelcoeffic
Copy link
Member

I believe the difference is really in the config stored on the touch controller, depending on which versions have been installed in between. My plan was to to see if I could download the existing config to compare and upload a new version if required.

@KevinFairgrieve
Copy link
Author

Rather than just hope, why not ask @wimalopaan what was configured differently in that firmware build? ;)

I have now done so. Thank you.

raphaelcoeffic added a commit that referenced this issue Sep 24, 2022
@pfeerick
Copy link
Member

pfeerick commented Sep 25, 2022

@KevinFairgrieve Are you in a position where you can see if #2351 / tomorrows nightly build will fix this for you? Basically, if that the TP input is still inverted with the build of firmware from that PR, there is now a mechanism by which you can reset the touch panel controller to find out if it is the problem. You should be able to plug the radio into your computer, choose the USB Serial (VCP) option, and then use a serial console tool like Putty to connect to the virtual serial port that is created (at 400,000 baud). When you press enter after opening the console up, you should get a prompt. You enter the reset_gt911 command, and press enter. It should tell you what the GT911 configuration value was, and what it is now. Hopefully, the touchpanel is also now the right way around.

If that seems too daunting, that's ok. And if you do want to give it a go, I'll try and walk you through it more if needed.

pfeerick pushed a commit that referenced this issue Sep 25, 2022
* GT911: add CLI command to reset config

Related to #2063

* X12S: touch coordinate inversion in GT911 config

Note: config reset with CLI "reset_gt911" required.

* Remove touch sensor software inversion
@KevinFairgrieve
Copy link
Author

@KevinFairgrieve Are you in a position where you can see if #2351 / tomorrows nightly build will fix this for you? Basically, if that the TP input is still inverted with the build of firmware from that PR, there is now a mechanism by which you can reset the touch panel controller to find out if it is the problem. You should be able to plug the radio into your computer, choose the USB Serial (VCP) option, and then use a serial console tool like Putty to connect to the virtual serial port that is created (at 400,000 baud). When you press enter after opening the console up, you should get a prompt. You enter the reset_gt911 command, and press enter. It should tell you what the GT911 configuration value was, and what it is now. Hopefully, the touchpanel is also now the right way around.

If that seems too daunting, that's ok. And if you do want to give it a go, I'll try and walk you through it more if needed.

Happy to give it a go.

I will download "putty" and the next nightly.

@raphaelcoeffic
Copy link
Member

@Luznatural most probably CLI is not set for the USB serial port. Go to the radio hardware settings, at the end of the page.

@Luznatural
Copy link

I have in the hardware tab of SYS in the X12S the USB-VCP to CLI, Aux1 OFF and port power off, and no luck.
Can you be so kind to Ispecify for me the connection data in PuTTY?
I have the following:
Serial line COM4
Speed (baud): 400000
Data bits:8
Stop bits: 1
Parity: None
Row control: XON/XOFF

More ideas?
Thanks in advance

@rotorman
Copy link
Member

rotorman commented Feb 10, 2023

Row control? You mean flow?
Anyhow, please try with hTerm instead, as with this all the settings are cleary visible on one page and if still no luck you could post the screenshot and one can easily see what the issue would be, if communication settings are wrong.

@pfeerick
Copy link
Member

I use Kitty, which is just a fork of Putty, and those settings look correct.

image

When you start the session, hit enter once, you should get the > prompt

image

I can't remember the default terminal settings on kitty/putty, you may want to check that also - specifically the Implicity CR/LF settings

image

@Luznatural
Copy link

Luznatural commented Feb 11, 2023

First, thanks to all for offering your savior counseils.
I have tried PuTTY, KiTTY and hTerm without success in my 3 different computers. It looks like my radio has something wrong with the VCP connection or something extrange (like myself) makes me unable to reset the touch screen.
I have also tried several different connection cables, just checking if it was a wiring problem.
No luck up to now.
I would like to know if you think there could be any alternate way to reset the screen using any command or making something that could modify it inside ETX, perhaps a LUA script, or producing a specific version of ETX for X12S that includes this reset in the core of the firmare.
Please, help this poor and desperate soul
Thanks in advance

@KevinFairgrieve
Copy link
Author

Just as an off chance, have you tried using one of the earlier versions from wimalopaan?

I found that using the test versions was OK then when 2.8.0 came out, mine just started working ok.

See my post above.

#2063 (comment)

It may be worth a shot.

@rotorman
Copy link
Member

@Luznatural can you show a screenshot of your hTerm?
Especially, did you set CR-LF for Send on Enter in the transmit side:
grafik

@Luznatural
Copy link

@Luznatural can you show a screenshot of your hTerm? Especially, did you set CR-LF for Send on Enter in the transmit side: grafik

Here you have a screenshot:
hterm
No luck connecting with the radio

@Luznatural
Copy link

Luznatural commented Feb 11, 2023

Just as an off chance, have you tried using one of the earlier versions from wimalopaan?

I found that using the test versions was OK then when 2.8.0 came out, mine just started working ok.

See my post above.

#2063 (comment)

It may be worth a shot.

I have not been able to find any file from @wimalopaan, except one named etx_x12s_de_2.8.0_wm_7_tuninv.bin that I tried also without luck. Everything continues the same.
The screen continues inverted.

I have used Windows 11 and Windows 8 to run PuTTY, KiTTY and H-term. Could that be part of the problem?

Thanks to all for your help.

@rotorman
Copy link
Member

@Luznatural Your baudrate looks wrong. Disconnect, change it to 400000, reconnect. Then put your cursor to the right of Type "ASC" field and press Enter there. Any improvement?

@Luznatural
Copy link

Yes!!!
Finaly I was able to connect and pressed reset_gt911 and the radio responded something like reset_gt911, your current configuration is "0" and then the screen started to work correctly.
Thanks to all for your patience with this very dumb guy.
As an aliby, I didn´t even remember how long ago I used a COM terminal.
Thanks again for your kind help

@KevinFairgrieve
Copy link
Author

Excellent. Now your TX12S will be the transmitter it should have been from the start.

If only it ran ETHOS as well!

@mervin1961
Copy link

Hi,
I just bought the gt911 touch panel for my Jumper T16 and I had the same problem. Reading this post I tried to reset gt911. It return with old version 109 and new version is 0 it turn the right side but from the center 2 to 2.5 cm the screen is inactive. Is there something else I can do to correct this? Thanks.

@rotorman
Copy link
Member

You can diagnose touch screen under hardware analogs diagnose page. Is the 0,0 point somewhere in the middle or is an area on one side cut? Would be easier to understand if you could make a small video tapping the screen at various points, while the analog diagnose page is open and post a link to that video here to see if it is a software or hardware issue.

@mervin1961
Copy link

Firstly thanks for the reply.
Check with diagnostics the left top in giving the maximum 81:0 that is if my finger is extreme top and extreme left and the right bottom is 479:271. Centre nothing happens. I have Hterm to reset the touch panel and the is the only software that works for me. I have already made a video and I will upload it here. Sorry for the video quality. I had to compress it from a 88mb to upload it here.

JumperT16.mp4

@mervin1961
Copy link

As you can see the main menu screen the 4 center selections icons are dead. As you already know before I did a reset the gt911 was diagonally opposite on the selection.

@rotorman
Copy link
Member

Can you please navigate first to analogs diagnose page and THEN tap the screen while doing a new video. You should see on the bottom of the screen the detected coordinates of your finger. I am interested to see which coordinates get detected and which not.

@mervin1961
Copy link

Uploading now. Please let me know if you need more videos. Thank you.

touch.coordinates.mp4

@rotorman
Copy link
Member

rotorman commented Jun 13, 2023

Can you try once more resetting the GT911 via CLI.
If that does not solve the issue, it seems to me that your touch panel layer is unfortunately defective.

P.S. In the last video you have a theme where some text is shown in black. Can you change to default theme and also list what is the output of the bottommost row.

@mervin1961
Copy link

Everything works before resetting only diagonally opposite or 180 degrees around.
Actually I have tried resetting many times but I will try again in fact hoping everything will be ok. Give me a few mins I will do another video.

@mervin1961
Copy link

reset again and results are old version 109 and new version 0. I hope this is the video you want.

touch.coordinates2.mp4

@mervin1961
Copy link

Just asking, does it have anything to do with the firmware version?

@rotorman
Copy link
Member

rotorman commented Jun 13, 2023

The video is good now, thanks. Shows what I was after. What EdgeTX version do you have flashed onto your Jumper T16 - how does the VERSION page look like?

@mervin1961
Copy link

Latest version 2.8.4. I have also tested with version 2.7.1 and selfbuild 2.9.0.

@mervin1961
Copy link

Version

@rotorman
Copy link
Member

@Stinky80 does it work for you with T16 and latest dev branch (I do not have T16 myself to test unfortunately)?

@mervin1961
Copy link

Sorry not sure what you mean. Just tell me what you want me to test.

@Stinky80
Copy link
Contributor

Stinky80 commented Jun 13, 2023 via email

@mervin1961
Copy link

Yes it seem to be working alright. So far haven't found any faults.
All you guys in here are doing wonderful things.
Thank you.

@mervin1961
Copy link

Anyway I am chatting with the seller on aliexpress regarding this issue. Hope this can be resolve. I have 2 units of this lcd one original in the Jumper and the other I bought maybe 3 or 4 years ago and I tried the display is correct installed ribbon upwards in the T16. Looks like radiomaster have some kind of agreement with the lcd suppliers because I can't find the lcd's anymore except for bulk order from abibaba. All the lcd's are 180 degrees around meaning correct view with ribbon installed downwards. I buy this because it is cheap for me. I live in Malaysia and retired and our currency is pretty bad now. Original touch panel from radiomasterrc.com would cost me about RM130 with shipping compared to gt911 only RM50.
Anyway thanks for you help. Really appreciated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting
Projects
None yet
Development

No branches or pull requests

9 participants