Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frsky X-lite Pro modifying menu items swiping right #4965

Closed
1 task done
Camo55 opened this issue May 4, 2024 · 6 comments · Fixed by #4967
Closed
1 task done

Frsky X-lite Pro modifying menu items swiping right #4965

Camo55 opened this issue May 4, 2024 · 6 comments · Fixed by #4967
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Milestone

Comments

@Camo55
Copy link

Camo55 commented May 4, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

20240504_030632.mp4

Sliding to the right while picking a letter results in the next letter being 'automatically' picked

Expected Behavior

Menu item is supposed to remain on the chosen setting when tapping sideways. Pressing to close the selection works normally.

Steps To Reproduce

Open menu,
Make menu text selection
Tap joystick to the right

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X-Lite / S / Pro

Operating System (OS)

Windows

OS Version

No response

Anything else?

Nightly build 5-4-2024, 2.10 RC4

@Camo55 Camo55 added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels May 4, 2024
@pfeerick
Copy link
Member

pfeerick commented May 4, 2024

It stems from #4884 and radio with LEFT and RIGHT keys ... I thought had caught the worst of it in #4917 but I think #3715 is still digging it's heels in 😮

From that I can tell it is XLite specific... LR3Pro hardware matches stimulator with rc4, and seems fine. T12 in simulator is fine also, so just leaves XLite navigation. Was hunting the wrong bug.

@pfeerick pfeerick added bug/regression ↩️ A new version of EdgeTX broke something and removed bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels May 4, 2024
@pfeerick pfeerick added this to the 2.10 milestone May 4, 2024
@philmoz
Copy link
Collaborator

philmoz commented May 4, 2024

T-Lite is also affected. Can you test PR #4967 on X-Lite radio.

@pfeerick
Copy link
Member

pfeerick commented May 4, 2024

Sorry, got caught up with another bug so thought they weren't affected. T12 and LR3Pro were affected by this also, and this resolves it for the LR3Pro on hardware, and X-Lite S on simulator, so just waiting for confirmation from OP. Also resolves my remaining bugbear from #4884 regarding popup menu navigation quirk.

@Camo55
Copy link
Author

Camo55 commented May 5, 2024

Sorry, got caught up with another bug so thought they weren't affected. T12 and LR3Pro were affected by this also, and this resolves it for the LR3Pro on hardware, and X-Lite S on simulator, so just waiting for confirmation from OP. Also resolves my remaining bugbear from #4884 regarding popup menu navigation quirk.

Is there a .bin file I can download to try the firmware update? I am a noob to github.

@pfeerick
Copy link
Member

pfeerick commented May 5, 2024

https://github.com/EdgeTX/edgetx/suites/23447572357/artifacts/1473568468 (zip file with all firmwares for that PR)

For future reference:

To access the automatic builds for a Pull Request (PR) you are interesting in trying out, first open up page for the PR in question. Under the title for the pull request, you should see a series of tabs (Comments, Commits, Checks, Files Changed). Click on the Checks tab.

If you are after the radio firmware, click on the link on the left side mentioning Firmware.
Or, if you want a Companion/Simulator build, pick the link on the left side mentioning Companion that suits your operating system.

Then, under the 'Artifacts' heading near the bottom of the page will be a link to the zip file containing either the firmware or companion package.

@Camo55
Copy link
Author

Camo55 commented May 5, 2024

Thank you! I have installed the firmware and can confirm the issue has been resolved!

@Camo55 Camo55 closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants