-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bw): multiple issues with menu navigation for 9X type radios #4884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good on LR3Pro and no apparent regressions on X9D+
evt == EVT_KEY_FIRST(KEY_MINUS) || evt == EVT_KEY_REPT(KEY_MINUS) || | ||
evt == EVT_ROTARY_RIGHT; | ||
} | ||
|
||
inline bool IS_PREVIOUS_EVENT(event_t evt) | ||
{ | ||
return evt == EVT_KEY_FIRST(KEY_UP) || evt == EVT_KEY_REPT(KEY_UP) || | ||
return evt == EVT_KEY_FIRST(KEY_LEFT) || evt == EVT_KEY_REPT(KEY_LEFT) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, why did you change this? As up/down was correct for popup menu navigation on the t-lite (and also the LR3pro I think). Hence #4917, although depending on the reason it may need to remove this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the left right scrolling on the SF/GF page for 9x nav - I fixed this first and meant to come back and check that it did not affect other things (which it clearly did). Thanks for picking it up - the fix in 4917 looks better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought that might be the case when digging a bit deeper... I suspect it is has been broken somewhere else, but that should hopefully do for now to make most all the use cases work. 🤞 Will need revisiting in the future though as the popup menus should't be responding to sideways keys, hence the real 🐛 is somewhere else 🤪
Co-authored-by: philmoz <philmoz@users.noreply.github.com>
From 2.10 the menu navigation on 9X style radios (T-Lite, T12 and LR3Pro) does not work correctly.
Issues:
Fixing the above issues caused other issues requiring more fixes (Model select page was one row short and FM edit page was missing G9 entry).