Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): multiple issues with menu navigation for 9X type radios #4884

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 16, 2024

From 2.10 the menu navigation on 9X style radios (T-Lite, T12 and LR3Pro) does not work correctly.

Issues:

  • Horizontal navigation on the SF/GF list does not work. Cannot select all properties for each SF/GF type.
  • The FM list view has too many lines. Scrolling up from the top shows two blank lines at the bottom.
  • Returning from the FM edit page to the FM list view may show the list view with the wrong scroll position if the edit page was scrolled to the bottom before exiting. Also affects other B&W radios when using long press to exit FM edit page.
  • The short press of the EXIT key following a long press to exit a subpage was not being killed resulting in spurious activation of the EXIT key. Also affects other B&W radios.

Fixing the above issues caused other issues requiring more fixes (Model select page was one row short and FM edit page was missing G9 entry).

@raphaelcoeffic raphaelcoeffic added this to the 2.10 milestone Apr 21, 2024
@pfeerick pfeerick changed the title fix(b&w): multiple issues with menu navigation for 9X type radios. fix(bw): multiple issues with menu navigation for 9X type radios Apr 21, 2024
@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Apr 21, 2024
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on LR3Pro and no apparent regressions on X9D+

@pfeerick pfeerick merged commit 4e2608f into EdgeTX:main Apr 23, 2024
44 checks passed
evt == EVT_KEY_FIRST(KEY_MINUS) || evt == EVT_KEY_REPT(KEY_MINUS) ||
evt == EVT_ROTARY_RIGHT;
}

inline bool IS_PREVIOUS_EVENT(event_t evt)
{
return evt == EVT_KEY_FIRST(KEY_UP) || evt == EVT_KEY_REPT(KEY_UP) ||
return evt == EVT_KEY_FIRST(KEY_LEFT) || evt == EVT_KEY_REPT(KEY_LEFT) ||
Copy link
Member

@pfeerick pfeerick Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why did you change this? As up/down was correct for popup menu navigation on the t-lite (and also the LR3pro I think). Hence #4917, although depending on the reason it may need to remove this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the left right scrolling on the SF/GF page for 9x nav - I fixed this first and meant to come back and check that it did not affect other things (which it clearly did). Thanks for picking it up - the fix in 4917 looks better.

Copy link
Member

@pfeerick pfeerick Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought that might be the case when digging a bit deeper... I suspect it is has been broken somewhere else, but that should hopefully do for now to make most all the use cases work. 🤞 Will need revisiting in the future though as the popup menus should't be responding to sideways keys, hence the real 🐛 is somewhere else 🤪

pfeerick added a commit that referenced this pull request Apr 24, 2024
Co-authored-by: philmoz <philmoz@users.noreply.github.com>
@philmoz philmoz deleted the fix-9x-key-nav branch July 6, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants