Fix thottle timer #3733
Merged
Fix thottle timer #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should the THR_STICK define be removed completely? It seems to be replaced by the mapping function. |
|
I'll check that |
|
I have done more fixes linked to THR_STICK , yet I don't think it should be removed altogether. |
|
Sounds good to me.
…On Fri, 30 June 2023, 4:32 pm 3djc, ***@***.***> wrote:
I'd rather get this one merged rapidly as it is an anoying bug, I'll look
into removing THR_STICK rapidly as a separate PR, because when browsing the
code, I saw a couple of places where it didn't look right
—
Reply to this email directly, view it on GitHub
<#3733 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KJ7BOSZY7ZUTY4OGQTXNZXHTANCNFSM6AAAAAAZYCNDJY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Closed
1 task
raphaelcoeffic
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes throttle timer not picking up the right channel by default after adc refactor