Include scale in getInput and insertInput #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using telemetry as an input, the scale field is used to convert from a value with units (like volts or meters) to a percentage. I'd like to modify an input's scale via Lua script. However this field does not seem to be supported by the Lua API. This seems like an oversight, so I added it.
raphaelcoeffic
approved these changes
Aug 12, 2023
|
@pguillory please add the new field to the documentation / comments before the functions. |
3djc
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Include scale in getInput and insertInput When using telemetry as an input, the scale field is used to convert from a value with units (like volts or meters) to a percentage. I'd like to modify an input's scale via Lua script. However this field does not seem to be supported by the Lua API. This seems like an oversight, so I added it. * chore: Add scale luadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using telemetry as an input, the scale field is used to convert from a value with units (like volts or meters) to a percentage. I'd like to modify an input's scale via Lua script. However this field does not seem to be supported by the Lua API. This seems like an oversight, so I added it.
Summary of changes:
Modify model.getInput and model.insertInput API to add the "scale" field.