Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yaml): Do not limit to static MPM protocol definitions #4146

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix(yaml): Do not limit to static MPM protocol definitions #4146

merged 3 commits into from
Oct 18, 2023

Conversation

raphaelcoeffic
Copy link
Member

Fixes #4144

@raphaelcoeffic raphaelcoeffic added this to the 2.9.x milestone Oct 1, 2023
@3djc
Copy link
Collaborator

3djc commented Oct 1, 2023

Colorlcd UI isn't handling it properly (yet ;))

image

@gagarinlg
Copy link
Member

We either have to store the protocol name or display the ID, when we do not have a name.

@3djc
Copy link
Collaborator

3djc commented Oct 1, 2023

BW > all ?

image

;)

@raphaelcoeffic
Copy link
Member Author

Screenshot 2023-10-01 at 15 37 09

@raphaelcoeffic raphaelcoeffic mentioned this pull request Oct 1, 2023
Closed
1 task
@pfeerick pfeerick mentioned this pull request Oct 2, 2023
Merged
@pfeerick pfeerick added bug 🪲 Something isn't working storage Related to loading, saving, converting labels Oct 3, 2023
@pfeerick pfeerick changed the title fix(yaml): do not rely on MPM protocol definitions fix(yaml): Do not rely on MPM protocol definitions Oct 3, 2023
@pfeerick pfeerick changed the title fix(yaml): Do not rely on MPM protocol definitions fix(yaml): Do not limit to static MPM protocol definitions Oct 18, 2023
@pfeerick pfeerick modified the milestones: 2.9.x, 2.9.2 Oct 18, 2023
@pfeerick
Copy link
Member

Tried with internal and external MPM on 1.3.3.33 with a previously unlisted protocol, TX16S, Zorro, X9D+2019 all seem to be working fine. If the protocol is not in the built-in list and the module is not present, the index number is shown instead, and you only lose the setting if you try to change it.

@pfeerick pfeerick merged commit 6d3aa57 into main Oct 18, 2023
37 checks passed
@pfeerick pfeerick deleted the fix-mpm-yaml branch October 18, 2023 09:24
pfeerick added a commit that referenced this pull request Oct 18, 2023
@pfeerick
fix(yaml): Do not limit to static MPM protocol definitions (#4146)
b395611
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
@pfeerick @MRC3742
fix(yaml): Do not limit to static MPM protocol definitions (EdgeTX#4146)
ed64ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🪲 Something isn't working storage Related to loading, saving, converting
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

Could not save for pre-release multiprotocol
4 participants
@raphaelcoeffic @3djc @gagarinlg @pfeerick