chore: auto select radio fastest supported baudrate for elrs #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Since we can just forward any support tickets that arise from this to the ELRS guys (since they are saying no issues will arise from this), I have no problem with this, and in merging it for 2.10. I do question the logic of people that think defaults should be max rather than a "guaranteed 100% working in all instances setting which you can later tweak for your circumstances" (note: this is not directed at the ELRS team, but rather some RCG commenters), but that's probably a personal bugbear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revisit #4523 based on latest info from ELRS team.
This only affect radio that go through the process of radio.yaml recreation