-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not display trims position when trim is set as 3POS #4777
Conversation
For color LCD this works already? |
Part of 2.10 rc1 readme: Unused trim switches can be used as 3POS switches |
Should've asked differently: |
I see, no it is not checking, but it is not checking either if trims are disabled I think. Could you have a look @philmoz ? |
Quick fix - add this between lines 2 and 3 of MainViewTrim::checkEvents() trim_t v = getRawTrimValue(mixerCurrentFlightMode, stickIndex);
if (v.mode == TRIM_MODE_NONE || v.mode == TRIM_MODE_3POS) {
// Hide trim if not being used
if (!lv_obj_has_flag(lvobj, LV_OBJ_FLAG_HIDDEN))
lv_obj_add_flag(lvobj, LV_OBJ_FLAG_HIDDEN);
return;
} else {
if (lv_obj_has_flag(lvobj, LV_OBJ_FLAG_HIDDEN))
lv_obj_clear_flag(lvobj, LV_OBJ_FLAG_HIDDEN);
} |
Do not draw the trim position indicator when trims are set to 3POS