fix: Stack overflow in some non-English language versions. #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow |
pfeerick
added
bug 🪲
pfeerick
pushed a commit
that referenced
this pull request
Mar 28, 2024
felipemanga
pushed a commit
to felipemanga/edgetx
that referenced
this pull request
Mar 29, 2024
ThomasKuehne
pushed a commit
to ThomasKuehne/edgetx
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modelHasNotes() function allocates a string on the stack that is only long enough to handle the English version of STR_MODEL.
When using a non-English language build where the STR_MODEL string has unicode characters encoded with 2-byte or 3-byte character sequences, the modelHasNotes() function will cause a stack overflow.