fix(usb): do not wait for send state #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelcoeffic
added
the
bug/regression ↩️
gagarinlg
approved these changes
Mar 29, 2024
`cdcConnected` is updated from the UI task and cannot be used here. Fixes #4740
pfeerick
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
re: #4740
During internal ELRS update via ELRS Configurator:
Pocket - no longer locks up
TX16S - no longer locks up
T14 - no longer locks up
Note: you need to unplug the USB after an ELRS update before the UI becomes responsive again. It will freeze from the moment the update process starts, until the USB is unplugged.
re: #4731
TX16S-MPM - no longer locks up, side note: Telem Mirror over USB working perfectly with my janky python test scipt
Pocket-ELRS - no lockup, serial data present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4731
Fixes #4740
Summary of changes:
usbSerialPutc().usbPlugged()instead ofcdcConnectedas the later is updated from the UI task which is blocked while in passthrough mode.