fix(color): personal templates saved to wrong folder

[philmoz]

Change personal template folder name to match SD card layout.

Fixes #4885

[pfeerick]

I see three options here:

• revert the change in the SD card pack
• merge this, and tell users rename the folders so they don't have two folders.
• silently rename on the handset if the old folder(s) are present...

I prefer the first out of simplicity, but think the third is better for end users as they don't need to do anything. Wizard and SoarETX (not SoarETXv2 as that is new) folders would also need renaming in that case if the old folder names present.

[philmoz]

It looks like the TEMPLATE folders were renamed Sep 2023 so reverting these would affect anyone who has updated their SD card contents.

It should be possible to add a startup check to rename folders (if the new ones are not present).
If both TEMPLATES/PERSONAL and TEMPLATES/2.Personal exist then we can move any files to the new folder.

[philmoz]

I've take a slightly different approach to the folder renaming concern.

If the new folder exists (2.Personal) the template is saved there.
If the new folder does not exist; but the old one does (PERSONAL), then the template is saved there.
If neither folder exists then the new folder is created and the template saved to it.

This way it works regardless of whether the user has updated their SD card contents or not.
It also avoid trying to guess what to do when both folders exist (i.e. it's up to the user to clean up).

[pfeerick]

And state would naturally be if both exist, it will use the new 2.Personal in preference to the old PERSONAL.

Sounds good to me... If there are two sets of folders I'm sure the user will do something about it then ;)