Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): profile conversion of models and settings #5151

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jun 10, 2024

Fixes #5137

Summary of changes:

  • fix use profile default hardware switch type when file switch type not supported eg convert 3 Position to 2 Position
  • fix hardware switch conversion to type (was reporting from)
  • add 'unsupported' conversion type
  • use 'unsupported' for hardware not existing in destination radio instead of 'invalid'
  • when values 'invalid' also report conversion applied (future merge invalid and conversion rows - separate in this PR for expediency)

Screenshot from 2024-06-11 07-20-24

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Jun 10, 2024
@elecpower elecpower added this to the 2.10.2 milestone Jun 10, 2024
@pfeerick
Copy link
Member

Seems to be working properly with issue model, and some other "incompatiable with other radios" profiles I have.

@pfeerick pfeerick merged commit 199e09e into main Jun 12, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-5137-prof-conv branch June 12, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion 2.10.1 - Profile conversion broken
2 participants