Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supported internal module for monochrome radios w/ ISRM #5236

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Jul 1, 2024

Fixes #5234
Fixes #5153

pfeerick: I am going to tentatively say this resolves #1942 also as this gem has been present since 2.6, so could have been responsible since it was a 2.7 issue.

Summary of changes:

  • use DEFAULT_INTERNAL_MODULE == ISRM_PXX2 as a better heuristic to determine the supported modules.

Note: it seems X9lite and X9liteS are impacted as well.

@raphaelcoeffic raphaelcoeffic added this to the 2.10.x milestone Jul 1, 2024
@pfeerick pfeerick added the bug 🪲 Something isn't working label Jul 1, 2024
@pfeerick
Copy link
Member

pfeerick commented Jul 1, 2024

Looks like I need to retag 2.10.2 due to some missing translations, so this should make that ;)

@pfeerick pfeerick modified the milestones: 2.10.x, 2.10.2 Jul 1, 2024
@pfeerick pfeerick merged commit 0aee0dd into main Jul 1, 2024
46 checks passed
@pfeerick pfeerick deleted the fix-internal-isrm branch July 1, 2024 08:31
@Fredflar
Copy link

Fredflar commented Jul 1, 2024

Danke für die Hilfe.
Habe die Radio.yml geändert. Musste danach aber die Settings, die Kalibrierung und die Globalen Variablen neu setzen.
Thanks for the help.
I changed the radio.yml. After that, however, the settings, calibration and the global variables had to be set up.

@pfeerick
Copy link
Member

pfeerick commented Jul 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
3 participants