Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): fixes and improvements for model setup page #5256

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jul 6, 2024

  • Fix: when the ENTER key is pressed on the center beep warning list to enter edit mode, the first value is also toggled (128x64).
  • Fix: 6POS switches are shown in center beep warning list (128x64).
  • Fix: disabled pots/sliders are shown in the center beep warning list.
  • Feat: hide the interactive checklist toggle if the checklist is disabled.
  • Feat: hide the throttle custom position settings if the throttle warning is disabled.
  • Feat: hide the throttle custom position value if the custom position check is disabled.

Potential candidate for 2.10.

@philmoz philmoz added bug 🪲 Something isn't working enhancement ✨ New feature or request B&W Related generally to black and white LCD radios labels Jul 6, 2024
@philmoz philmoz added this to the 2.11 milestone Jul 6, 2024
@pfeerick pfeerick changed the title fix(b&w): fixes and improvements for B&W model setup page. fix(bw): fixes and improvements for model setup page Jul 6, 2024
@pfeerick pfeerick modified the milestones: 2.11, 2.10.x Jul 7, 2024
@pfeerick
Copy link
Member

pfeerick commented Jul 7, 2024

Fantastic... looks good on TX12 and X9D+2019 :)

@pfeerick pfeerick merged commit 0fc22a3 into main Jul 7, 2024
46 checks passed
@pfeerick pfeerick deleted the philmoz/bw-model-setup branch July 7, 2024 01:52
pfeerick pushed a commit that referenced this pull request Jul 7, 2024
Fix: when the ENTER key is pressed on the center beep warning list to enter edit mode, the first value is also toggled (128x64).
Fix: 6POS switches are shown in center beep warning list (128x64).
Fix: disabled pots/sliders are shown in the center beep warning list.
Feat: hide the interactive checklist toggle if the checklist is disabled.
Feat: hide the throttle custom position settings if the throttle warning is disabled.
Feat: hide the throttle custom position value if the custom position check is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants