Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telemetry buffer for all internal modules #5267

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Jul 8, 2024

Targets which did not have support for CRSF or MULTI internal module (ex: X9D+ 2019, X7 ACCESS, NV14) would use a single telemetry buffer for internal and external module, thus causing clashes when 2 modules are used in parallel. This would for instance prevent using an external MPM as trainer module.

Please note that this will slightly increases memory usage for the targets mentioned above (up to 128 bytes).

Summary of changes:

  • enable telemetry buffer for targets without CRSF or MULTI internal module support compiled into the firmware.

@3djc
Copy link
Collaborator

3djc commented Jul 8, 2024

128 bytes ! Hurts, but needed I guess

@raphaelcoeffic
Copy link
Member Author

128 bytes ! Hurts, but needed I guess

You don't cook omelette without breaking eggs 😇

@pfeerick
Copy link
Member

pfeerick commented Jul 8, 2024

This would for instance prevent using an external MPM as trainer module.

Hm... well, unless we were deciding that this is no longer a feature, it's not really an option but to lose some bytes... been nice knowing you, 128 bytes of SRAM 😆 You will be sorely missed I'm sure, especially on low SRAM transmitters! 🙃

@3djc
Copy link
Collaborator

3djc commented Jul 8, 2024

I think we are all violently agreeing here :)

@pfeerick pfeerick added bug 🪲 Something isn't working enhancement ✨ New feature or request labels Jul 8, 2024
@pfeerick pfeerick added this to the 2.10.x milestone Jul 8, 2024
@pfeerick pfeerick merged commit 9518dca into main Jul 8, 2024
46 checks passed
@pfeerick pfeerick deleted the internal-module-buffer branch July 8, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants