chore: more OTX to ETX housekeeping #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
added
compilation
pfeerick
force-pushed
the
pfeerick/otx-to-etx
branch
2 times, most recently
from
1d9b123
to
c74155e
Compare
|
Curious as to what this means: '- LVGL font code doesn't like pragma,' |
|
You could try it yourself :-P And witness all the noise from the compiler about pragma being used in the font |
|
I changed lv_conf.h and had no issues? |
|
Wasn't that changed in this PR, so shouldn't be one of the listed exceptions? I'm referring to these include style guard defines... in the LVGL font code c files... |
|
I didn't consider those as they are auto-generated by the lv_font_conv tool - hence my confusion. |
|
Sorry about that! Yeah, and no apparent options to change that formatting, so it got added to the ignore list. This is probably done for now anyway, as I'm not touching Companion side at all (yet?!). |
Exceptions: - LVGL font code doesn't like pragma, - thirdparty libraries - STM32 generated headers
pfeerick
force-pushed
the
pfeerick/otx-to-etx
branch
from
c74155e
to
7f3a452
Compare
richardclli
added a commit
that referenced
this pull request
Aug 18, 2024
pfeerick
added a commit
that referenced
this pull request
Aug 19, 2024
richardclli
added a commit
that referenced
this pull request
Aug 21, 2024
richardclli
added a commit
that referenced
this pull request
Aug 23, 2024
richardclli
added a commit
that referenced
this pull request
Aug 26, 2024
richardclli
added a commit
that referenced
this pull request
Aug 28, 2024
pfeerick
added a commit
that referenced
this pull request
Aug 28, 2024
pfeerick
added a commit
that referenced
this pull request
Aug 29, 2024
richardclli
added a commit
that referenced
this pull request
Sep 2, 2024
richardclli
added a commit
that referenced
this pull request
Sep 5, 2024
richardclli
added a commit
that referenced
this pull request
Sep 6, 2024
richardclli
added a commit
that referenced
this pull request
Sep 11, 2024
richardclli
added a commit
that referenced
this pull request
Sep 12, 2024
richardclli
added a commit
that referenced
this pull request
Sep 18, 2024
richardclli
added a commit
that referenced
this pull request
Sep 20, 2024
richardclli
added a commit
that referenced
this pull request
Sep 29, 2024
richardclli
added a commit
that referenced
this pull request
Oct 1, 2024
richardclli
added a commit
that referenced
this pull request
Oct 14, 2024
richardclli
added a commit
that referenced
this pull request
Oct 16, 2024
richardclli
added a commit
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Although it affects significant number of files, should be unobtrusive enough to not break other PRs. Next up is changing over to
#PRAGMA...