fix(flysky): battery charging animation and other timing issues #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
changed the title
Also update PL18 tap timeout and comments
pfeerick
reviewed
Aug 23, 2024
| @@ -175,7 +175,7 @@ void handle_battery_charge(uint32_t last_press_time) | |||
| return; | |||
| } | |||
|
|
|||
| if(updateTime == 0 || ((get_tmr10ms() - updateTime) >= 50)) | |||
| if(updateTime == 0 || ((timersGetMsTick() - updateTime) >= 500)) | |||
There was a problem hiding this comment.
Can we change the 500 to a constant, rather than a magic number for half second? ;) For both NV14/PL18, etc... can be in the common PR if not already there...
|
Battery animation good now on PL18EV and NV14. Touch is working fine also. There appears to be a pre-existing issue still with tap counting on NV14. |
pfeerick
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Battery charging animation problem due to PR#5424