Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: special function to push customisable switches #5497

Merged
merged 17 commits into from
Sep 14, 2024
Merged

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Sep 2, 2024

Thanks @philmoz for colorlcd UI

Fixes #5487

@3djc 3djc marked this pull request as draft September 2, 2024 12:36
@pfeerick pfeerick changed the title Add a function to push customisable switches feat: Special function to push customisable switches Sep 2, 2024
@pfeerick pfeerick added the enhancement ✨ New feature or request label Sep 2, 2024
@pfeerick pfeerick changed the title feat: Special function to push customisable switches feat: special function to push customisable switches Sep 2, 2024
@3djc
Copy link
Collaborator Author

3djc commented Sep 9, 2024

@elecpower , could you do the Companion piece ?
Basically this adds a special func for radio with customisable switches, with 2 params:

  • which switch ? SW1 to SWx (num function switch)
  • duration; 0 to 25.5s, store exactly like SDLogs (value is in tenth of seconds)

@3djc 3djc marked this pull request as ready for review September 9, 2024 09:22
@elecpower
Copy link
Collaborator

@elecpower , could you do the Companion piece ?
Basically this adds a special func for radio with customisable switches, with 2 params:

  • which switch ? SW1 to SWx (num function switch)
  • duration; 0 to 25.5s, store exactly like SDLogs (value is in tenth of seconds)

Yes

@elecpower
Copy link
Collaborator

Subject to a blunder on my part, I'm done, so back to you to test.

@pfeerick
Copy link
Member

pfeerick commented Sep 12, 2024

Rebased on main (due to conflicts from #5523). Only changes I made along the way were to add a few more #if defined(FUNCTION_SWITCHES), which then limited yaml storage changes only to radios with CS... passed build and unit tests locally for TPro, TPro S, T15 and TX16S, but otherwise untested at this point. Feel free to push own rebase if you prefer or if something got clobbered along the way...

@pfeerick pfeerick added this to the 2.11 milestone Sep 12, 2024
@3djc
Copy link
Collaborator Author

3djc commented Sep 12, 2024

Seems to work perfectly ! Thanks @elecpower !

Tested from and to T15

@pfeerick
Copy link
Member

Firmware (T20) and Companion (linux) LGTM :)

@pfeerick pfeerick merged commit d417228 into main Sep 14, 2024
51 checks passed
@pfeerick pfeerick deleted the 3djc/CS-SF branch September 14, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the state of customizable buttons via special functions
3 participants