Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): CS values may be read incorrectly from yaml #5515

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Sep 6, 2024

Fixes #5510

Incorrect length passed when converting int value for CS position.
If additional character is a digit then bad index value is calculated.

Also needs to be applied to 2.10.5.

@philmoz philmoz added bug 🪲 Something isn't working color Related generally to color LCD radios B&W Related generally to black and white LCD radios labels Sep 6, 2024
@philmoz philmoz added this to the 2.11 milestone Sep 6, 2024
@pfeerick pfeerick modified the milestones: 2.11, 2.10.5 Sep 6, 2024
@pfeerick
Copy link
Member

pfeerick commented Sep 8, 2024

Seems ok on T15

@pfeerick pfeerick changed the title fix(radio): CS values may be read incorrectly from model yaml file. fix(radio): CS values may be read incorrectly from yaml Sep 8, 2024
@pfeerick pfeerick merged commit 4f88ed4 into main Sep 8, 2024
48 checks passed
@pfeerick pfeerick deleted the philmoz/fix-cs-read branch September 8, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical Switch does not save / gets scrambled
2 participants