fix(radio): writing of .luac files can fail on some radios #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for it, it is definitely an improvement for all radio to 'hammer' less the sdcard, but I need to emphasis it does not solve the yet unidentified root cause of #5702 |
pfeerick
changed the title
…e in larger blocks.
philmoz
force-pushed
the
philmoz/lua-dumper
branch
from
d760143 to
6cd3672
Compare
This was referenced Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the compiled .luac file for a script the file write may be done with a large number of very small writes to the SD card. For some reason this is failing on the GX12 with some scripts.
This PR buffers the data being written when a .luac file is generated and writes it in larger blocks to the SD card.
This is a workaround for the GX12 issue; but may also reduce the SD write overhead when creating .luac files.
Note: the underlying issue with the GX12 SD writing should still be investigated and fixed.
Resolves #5702 but does not fix underlying issue.