phpmetrics - allow git statistics in .phpqa.yml

Closes #122
EdgedesignCZ · Mar 31, 2018 · ec55df8 · ec55df8
1 parent 03587df
commit ec55df8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/.phpqa.yml b/.phpqa.yml
@@ -29,7 +29,10 @@ phpcpd:
     minTokens: 70
 
 phpmetrics:
+    # v1
     config: null
+    # v2
+    git: false
 
 phpstan:
     level: 0

diff --git a/README.md b/README.md
@@ -225,6 +225,8 @@ Tool | Settings | Default Value | Your value
 [php-cs-fixer.allowRiskyRules](http://cs.sensiolabs.org/#usage) | Whether risky rules may run  | `false` | Boolean value
 [php-cs-fixer.config](http://cs.sensiolabs.org/#usage) | Load configuration from [file](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/.php_cs.dist) | `null` | Path to `.phpcs` file
 [php-cs-fixer.isDryRun](http://cs.sensiolabs.org/#usage) | If code is just analyzed or fixers are applied  | `true` | Boolean value
+[phpmetrics.config](https://github.com/EdgedesignCZ/phpqa/issues/74) | Configuration for phpmetrics v1  | `null` | Path to `.phpmetrics.yml` file
+[phpmetrics.git](https://github.com/EdgedesignCZ/phpqa/issues/74) | phpmetrics v2 supports basic git statistics  | `null` | Boolean value or path to git binary
 [phpmd](http://phpmd.org/documentation/creating-a-ruleset.html) | Ruleset | [Edgedesign's standard](/app/phpmd.xml) | Path to ruleset
 [phpcpd](https://github.com/sebastianbergmann/phpcpd/blob/de9056615da6c1230f3294384055fa7d722c38fa/src/CLI/Command.php#L136) | Minimum number of lines/tokens for copy-paste detection | 5 lines, 70 tokens |
 [phpstan](https://github.com/phpstan/phpstan#configuration) | Level, config file | Level 0, `%currentWorkingDirectory%/phpstan.neon` | Take a look at [phpqa config in tests/.travis](/tests/.travis/) |

diff --git a/src/Tools/Analyzer/PhpMetricsV2.php b/src/Tools/Analyzer/PhpMetricsV2.php
@@ -20,6 +20,10 @@ public function __invoke()
             $args['report-html'] = $this->options->toFile('phpmetrics/');
             $args['report-violations'] = $this->options->toFile('phpmetrics.xml');
         }
+        $gitBinary = $this->config->value('phpmetrics.git');
+        if ($gitBinary) {
+            $args['git'] = is_file($gitBinary) ? $gitBinary : 'git';
+        }
         $args[] = $this->options->getAnalyzedDirs(',');
         return $args;
     }

diff --git a/tests/Config/ConfigTest.php b/tests/Config/ConfigTest.php
@@ -29,6 +29,8 @@ public function testLoadDefaultConfig()
         assertThat($config->value('psalm.deadCode'), identicalTo(false));
         assertThat($config->value('psalm.threads'), identicalTo(1));
         assertThat($config->value('psalm.showInfo'), identicalTo(true));
+        assertThat($config->value('phpmetrics.config'), is(nullValue()));
+        assertThat($config->value('phpmetrics.git'), identicalTo(false));
     }
 
     public function testBuildAbsolutePath()