Merge branch 'master' into PA-testing

.devcontainer/devcontainer.json

@@ -14,6 +14,7 @@
     "force_color_prompt": "1"
   },
   "runArgs": [
+    "--volume=/dev:/dev",
     "--volume=/tmp/.X11-unix:/tmp/.X11-unix",
     "--volume=${localWorkspaceFolder}/.devcontainer/.host/.Xauthority:/home/batman/.Xauthority",
     "--volume=${localEnv:HOME}/.comma:/home/batman/.comma",
@@ -49,4 +50,4 @@
   "mounts": [
     "type=volume,source=scons_cache,target=/tmp/scons_cache"
   ]
-}
+}

.github/workflows/auto_pr_review.yaml

@@ -5,7 +5,7 @@ on:
 
 jobs:
   labeler:
-    name: apply labels
+    name: review
     permissions:
       contents: read
       pull-requests: write
@@ -14,17 +14,17 @@ jobs:
     - uses: actions/checkout@v4
       with:
         submodules: false
+
+    # Label PRs
     - uses: actions/labeler@v5.0.0
       with:
         dot: true
         configuration-path: .github/labeler.yaml
 
-  pr_branch_check:
-    name: check branch
-    runs-on: ubuntu-latest
-    if: github.repository == 'commaai/openpilot'
-    steps:
-    - uses: Vankka/pr-target-branch-action@def32ec9d93514138d6ac0132ee62e120a72aed5
+    # Check PR target branch
+    - name: check branch
+      uses: Vankka/pr-target-branch-action@def32ec9d93514138d6ac0132ee62e120a72aed5
+      if: github.repository == 'commaai/openpilot'
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
@@ -34,194 +34,20 @@ jobs:
         already-exists-action: close_this
         already-exists-comment: "Your PR should be made against the `master` branch"
 
-  comment:
-    runs-on: ubuntu-latest
-    steps:
-      - name: comment
-        uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6
-        if: github.event.pull_request.head.repo.full_name != 'commaai/openpilot'
-        with:
-          message: |
-              <!-- _(run_id **${{ github.run_id }}**)_ -->
-              Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
-              * Convert your PR to a draft unless it's ready to review
-              * Read the [contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md)
-              * Before marking as "ready for review", ensure:
-                * the goal is clearly stated in the description
-                * all the tests are passing
-                * the change is [something we merge](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-gets-merged)
-                * include a route or your device' dongle ID if relevant
-          comment_tag: run_id
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-  check-pr-template:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      issues: write
-      pull-requests: write
-      actions: read
-    if: false && github.event.pull_request.head.repo.full_name != 'commaai/openpilot'
-    steps:
-      - uses: actions/github-script@v7
-        with:
-          script: |
-            // Comment to add to the PR if no template has been used
-            const NO_TEMPLATE_MESSAGE =
-              "It looks like you didn't use one of the Pull Request templates. Please check [the contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md). \
-            Also make sure that you didn't modify any of the checkboxes or headings within the template.";
-            // body data for future requests
-            const body_data = {
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-            };
-
-            // Utility function to extract all headings
-            const extractHeadings = (markdown) => {
-              const headingRegex = /^(#{1,6})\s+(.+)$/gm;
-              const boldTextRegex = /^(?:\*\*|__)(.+?)(?:\*\*|__)\s*$/gm;
-              const headings = [];
-              let headingMatch;
-              while ((headingMatch = headingRegex.exec(markdown))) {
-                headings.push(headingMatch[2].trim());
-              }
-              let boldMatch;
-              while ((boldMatch = boldTextRegex.exec(markdown))) {
-                headings.push(boldMatch[1].trim());
-              }
-              return headings;
-            };
-
-            // Utility function to extract all check box descriptions
-            const extractCheckBoxTexts = (markdown) => {
-              const checkboxRegex = /^\s*-\s*\[( |x)\]\s+(.+)$/gm;
-              const checkboxes = [];
-              let match;
-              while ((match = checkboxRegex.exec(markdown))) {
-                checkboxes.push(match[2].trim());
-              }
-              return checkboxes;
-            };
-
-            // Utility function to check if a list is a subset of another list
-            isSubset = (subset, superset) => {
-              return subset.every((item) => superset.includes(item));
-            };
-
-            // Utility function to check if a list of checkboxes is a subset of another list of checkboxes
-            isCheckboxSubset = (templateCheckBoxTexts, prTextCheckBoxTexts) => {
-              // Check if each template checkbox text is a substring of at least one PR checkbox text
-              // (user should be allowed to add additional text)
-              return templateCheckBoxTexts.every((item) => prTextCheckBoxTexts.some((element) => element.includes(item)))
-            }
-
-            // Get filenames of all currently checked-in PR templates
-            const template_contents = await github.rest.repos.getContent({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              path: ".github/PULL_REQUEST_TEMPLATE",
-            });
-            var template_filenames = [];
-            for (const content of template_contents.data) {
-              template_filenames.push(content.path);
-            }
-            console.debug("Received template filenames: " + template_filenames);
-            // Retrieve templates
-            var templates = [];
-            for (const template_filename of template_filenames) {
-              const template_response = await github.rest.repos.getContent({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                path: template_filename,
-              });
-              // Convert Base64 content back
-              const decoded_template = atob(template_response.data.content);
-              const headings = extractHeadings(decoded_template);
-              const checkboxes = extractCheckBoxTexts(decoded_template);
-              if (!headings.length && !checkboxes.length) {
-                console.warn(
-                  "Invalid template! Contains neither headings nor checkboxes, ignoring it: \n" +
-                    decoded_template
-                );
-              } else {
-                templates.push({ headings: headings, checkboxes: checkboxes });
-              }
-            }
-            // Retrieve the PR Body
-            const pull_request = await github.rest.issues.get({
-              ...body_data,
-            });
-            const pull_request_text = pull_request.data.body;
-            console.debug("Received Pull Request body: \n" + pull_request_text);
-
-            /* Check if the PR Body matches one of the templates
-            A template is defined by all headings and checkboxes it contains
-            We extract all Headings and Checkboxes from the PR text and check if any of the templates is a subset of that
-            */
-            const pr_headings = extractHeadings(pull_request_text);
-            const pr_checkboxes = extractCheckBoxTexts(pull_request_text);
-            console.debug("Found Headings in PR body:\n" + pr_headings);
-            console.debug("Found Checkboxes in PR body:\n" + pr_checkboxes);
-            var template_found = false;
-            // Iterate over each template to check if it applies
-            for (const template of templates) {
-              console.log(
-                "Checking for headings: [" +
-                  template.headings +
-                  "] and checkboxes: [" +
-                  template.checkboxes + "]"
-              );
-              if (
-                isCheckboxSubset(template.checkboxes, pr_checkboxes) &&
-                isSubset(template.headings, pr_headings)
-              ) {
-                console.debug("Found matching template!");
-                template_found = true;
-              }
-            }
-
-            // List comments from previous runs
-            var existing_comments = [];
-            const comments = await github.rest.issues.listComments({
-              ...body_data,
-            });
-            for (const comment of comments.data) {
-              if (comment.body === NO_TEMPLATE_MESSAGE) {
-                existing_comments.push(comment);
-              }
-            }
-
-            // Add a comment to the PR that it is not using a the template (but only if this comment does not exist already)
-            if (!template_found) {
-              var comment_already_sent = false;
-
-              // Add an 'in-bot-review' label since this PR doesn't have the template
-              github.rest.issues.addLabels({
-                ...body_data,
-                labels: ["in-bot-review"],
-              });
-
-              if (existing_comments.length < 1) {
-                github.rest.issues.createComment({
-                  ...body_data,
-                  body: NO_TEMPLATE_MESSAGE,
-                });
-              }
-            } else {
-              // If template has been found, delete any old comment about missing template
-              for (const existing_comment of existing_comments) {
-                github.rest.issues.deleteComment({
-                  ...body_data,
-                  comment_id: existing_comment.id,
-                });
-              }
-              // Remove the 'in-bot-review' label after the review is done and the PR has passed
-              github.rest.issues.removeLabel({
-                ...body_data,
-                name: "in-bot-review",
-              }).catch((error) => {
-                console.log("Label 'in-bot-review' not found, ignoring");
-              });
-            }
-
+    # Welcome comment
+    - name: comment
+      uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6
+      if: github.event.pull_request.head.repo.full_name != 'commaai/openpilot'
+      with:
+        message: |
+            <!-- _(run_id **${{ github.run_id }}**)_ -->
+            Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
+            * Convert your PR to a draft unless it's ready to review
+            * Read the [contributing docs](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md)
+            * Before marking as "ready for review", ensure:
+              * the goal is clearly stated in the description
+              * all the tests are passing
+              * the change is [something we merge](https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-gets-merged)
+              * include a route or your device' dongle ID if relevant
+        comment_tag: run_id
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/selfdrive_tests.yaml

@@ -76,37 +76,23 @@ jobs:
     - uses: actions/checkout@v4
       with:
         submodules: true
-    - uses: ./.github/workflows/setup-with-retry
-      with:
-        docker_hub_pat: ${{ secrets.DOCKER_HUB_PAT }}
-    - uses: ./.github/workflows/compile-openpilot
-      timeout-minutes: ${{ ((steps.restore-scons-cache.outputs.cache-hit == 'true') && 15 || 30) }} # allow more time when we missed the scons cache
-
-  docker_push:
-    name: docker push
-    strategy:
-      matrix:
-        arch: ${{ fromJson( (github.repository == 'commaai/openpilot') && '["x86_64", "aarch64"]' || '["x86_64"]' ) }}
-    runs-on: ${{ (matrix.arch == 'aarch64') && 'namespace-profile-arm64-2x8' || 'ubuntu-latest' }}
-    if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/openpilot'
-    steps:
-    - uses: actions/checkout@v4
-      with:
-        submodules: true
-    - name: Setup to push to repo
+    - name: Setup docker push
+      if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/openpilot'
       run: |
         echo "PUSH_IMAGE=true" >> "$GITHUB_ENV"
         echo "TARGET_ARCHITECTURE=${{ matrix.arch }}" >> "$GITHUB_ENV"
         $DOCKER_LOGIN
     - uses: ./.github/workflows/setup-with-retry
       with:
         docker_hub_pat: ${{ secrets.DOCKER_HUB_PAT }}
+    - uses: ./.github/workflows/compile-openpilot
+      timeout-minutes: ${{ ((steps.restore-scons-cache.outputs.cache-hit == 'true') && 15 || 30) }} # allow more time when we missed the scons cache
 
   docker_push_multiarch:
     name: docker push multiarch tag
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'commaai/openpilot'
-    needs: [docker_push]
+    needs: [build]
     steps:
     - uses: actions/checkout@v4
       with:

.github/workflows/tools_tests.yaml

@@ -59,7 +59,7 @@ jobs:
         ${{ env.RUN }} "export MAPBOX_TOKEN='pk.eyJ1Ijoiam5ld2IiLCJhIjoiY2xxNW8zZXprMGw1ZzJwbzZneHd2NHljbSJ9.gV7VPRfbXFetD-1OVF0XZg' && \
                         source selfdrive/test/setup_xvfb.sh && \
                         source selfdrive/test/setup_vsound.sh && \
-                        CI=1 pytest tools/sim/tests/test_metadrive_bridge.py -W ignore::pyopencl.CompilerWarning"
+                        CI=1 pytest tools/sim/tests/test_metadrive_bridge.py"
 
   devcontainer:
     name: devcontainer

.gitignore

@@ -55,12 +55,8 @@ selfdrive/modeld/_modeld
 selfdrive/modeld/_dmonitoringmodeld
 /src/
 
-one
 notebooks
-xx
-yy
 hyperthneed
-panda_jungle
 provisioning
 
 .coverage*

.pre-commit-config.yaml

@@ -47,7 +47,7 @@ repos:
         args:
         - --local-partial-types
         - --explicit-package-bases
-        exclude: '^(third_party/)|(cereal/)|(opendbc/)|(panda/)|(rednose/)|(rednose_repo/)|(tinygrad/)|(tinygrad_repo/)|(teleoprtc/)|(teleoprtc_repo/)|(xx/)'
+        exclude: '^(third_party/)|(cereal/)|(opendbc/)|(panda/)|(rednose/)|(rednose_repo/)|(tinygrad/)|(tinygrad_repo/)|(teleoprtc/)|(teleoprtc_repo/)'
 -   repo: local
     hooks:
     -   id: cppcheck
@@ -89,7 +89,7 @@ repos:
         entry: selfdrive/ui/tests/test_translations.py
         language: script
         pass_filenames: false
-        files: 'selfdrive/ui/translations/*'
+        files: '^selfdrive/ui/translations/'
 -   repo: https://github.com/python-poetry/poetry
     rev: '1.8.0'
     hooks:

Dockerfile.openpilot_base

@@ -13,14 +13,10 @@ ENV LANGUAGE en_US:en
 ENV LC_ALL en_US.UTF-8
 
 COPY tools/install_ubuntu_dependencies.sh /tmp/tools/
-RUN cd /tmp && \
-    tools/install_ubuntu_dependencies.sh && \
-    rm -rf /var/lib/apt/lists/* && \
-    rm -rf /tmp/* && \
-    # remove unused architectures from gcc for panda
+RUN INSTALL_EXTRA_PACKAGES=no /tmp/tools/install_ubuntu_dependencies.sh && \
+    rm -rf /var/lib/apt/lists/* /tmp/* && \
     cd /usr/lib/gcc/arm-none-eabi/9.2.1 && \
-    rm -rf arm/ && \
-    rm -rf thumb/nofp thumb/v6* thumb/v8* thumb/v7+fp thumb/v7-r+fp.sp
+    rm -rf arm/ thumb/nofp thumb/v6* thumb/v8* thumb/v7+fp thumb/v7-r+fp.sp
 
 # Add OpenCL
 RUN apt-get update && apt-get install -y --no-install-recommends \
@@ -83,4 +79,4 @@ RUN cd /tmp && \
     rm -rf /home/$USER/pyenv/versions/3.11.4/lib/python3.11/test
 
 USER root
-RUN sudo git config --global --add safe.directory /tmp/openpilot
+RUN sudo git config --global --add safe.directory /tmp/openpilot

common/api/__init__.py

@@ -7,7 +7,7 @@
 
 API_HOST = os.getenv('API_HOST', 'https://api.commadotai.com')
 
-class Api():
+class Api:
   def __init__(self, dongle_id):
     self.dongle_id = dongle_id
     with open(Paths.persist_root()+'/comma/id_rsa') as f:

common/gpio.py

@@ -1,5 +1,5 @@
 import os
-from functools import lru_cache
+from functools import cache
 
 def gpio_init(pin: int, output: bool) -> None:
   try:
@@ -35,7 +35,7 @@ def gpio_export(pin: int) -> None:
   except Exception:
     print(f"Failed to export gpio {pin}")
 
-@lru_cache(maxsize=None)
+@cache
 def get_irq_action(irq: int) -> list[str]:
   try:
     with open(f"/sys/kernel/irq/{irq}/actions") as f: