Flow: make more objects exact (facebook#27790)

This makes a couple objects more exact. Nothing critical, just noticed this old branch I had created when doing some Flow upgrades in the past.
EdisonVan · Apr 15, 2024 · 7a9ad05 · 7a9ad05
1 parent 8dc216b
commit 7a9ad05
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 21 deletions.
diff --git a/packages/react-debug-tools/src/ReactDebugHooks.js b/packages/react-debug-tools/src/ReactDebugHooks.js
@@ -36,7 +36,6 @@ type HookLogEntry = {
   primitive: string,
   stackError: Error,
   value: mixed,
-  ...
 };
 
 let hookLog: Array<HookLogEntry> = [];
@@ -408,7 +407,6 @@ export type HooksNode = {
   value: mixed,
   subHooks: Array<HooksNode>,
   hookSource?: HookSource,
-  ...
 };
 export type HooksTree = Array<HooksNode>;
 

diff --git a/packages/react-devtools-core/src/backend.js b/packages/react-devtools-core/src/backend.js
@@ -36,7 +36,6 @@ type ConnectOptions = {
   isAppActive?: () => boolean,
   websocket?: ?WebSocket,
   devToolsSettingsManager: ?DevToolsSettingsManager,
-  ...
 };
 
 // Install a global variable to allow patching console early (during injection).

diff --git a/packages/react-devtools-shared/src/devtools/cache.js b/packages/react-devtools-shared/src/devtools/cache.js
@@ -53,7 +53,6 @@ export type Resource<Input, Key, Value> = {
   read(Input): Value,
   preload(Input): void,
   write(Key, Value): void,
-  ...
 };
 
 const Pending = 0;

diff --git a/...es/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/AutoSizeInput.js b/...es/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/AutoSizeInput.js
@@ -16,7 +16,6 @@ type Props = {
   placeholder?: string,
   testName?: ?string,
   value: any,
-  ...
 };
 
 export default function AutoSizeInput({

diff --git a/packages/react-devtools-shared/src/devtools/views/Components/OwnersStack.js b/packages/react-devtools-shared/src/devtools/views/Components/OwnersStack.js
@@ -202,7 +202,6 @@ type ElementsDropdownProps = {
   owners: Array<SerializedElement>,
   selectedIndex: number,
   selectOwner: SelectOwner,
-  ...
 };
 function ElementsDropdown({owners, selectOwner}: ElementsDropdownProps) {
   const store = useContext(StoreContext);

diff --git a/packages/react-devtools-shared/src/devtools/views/Profiler/CommitRankedListItem.js b/packages/react-devtools-shared/src/devtools/views/Profiler/CommitRankedListItem.js
@@ -21,7 +21,6 @@ type Props = {
   data: ItemData,
   index: number,
   style: Object,
-  ...
 };
 
 function CommitRankedListItem({data, index, style}: Props) {

diff --git a/packages/react-devtools-shared/src/hydration.js b/packages/react-devtools-shared/src/hydration.js
@@ -427,7 +427,7 @@ export function hydrate(
       parent[last] = undefined;
     } else {
       // Replace the string keys with Symbols so they're non-enumerable.
-      const replaced: {[key: symbol]: boolean | string, ...} = {};
+      const replaced: {[key: symbol]: boolean | string} = {};
       replaced[meta.inspectable] = !!value.inspectable;
       replaced[meta.inspected] = false;
       replaced[meta.name] = value.name;

diff --git a/packages/react-dom/src/client/ReactDOMRoot.js b/packages/react-dom/src/client/ReactDOMRoot.js
@@ -35,15 +35,14 @@ export type RootType = {
   render(children: ReactNodeList): void,
   unmount(): void,
   _internalRoot: FiberRoot | null,
-  ...
 };
+
 export type CreateRootOptions = {
   unstable_strictMode?: boolean,
   unstable_concurrentUpdatesByDefault?: boolean,
   unstable_transitionCallbacks?: TransitionTracingCallbacks,
   identifierPrefix?: string,
   onRecoverableError?: (error: mixed) => void,
-  ...
 };
 
 export type HydrateRootOptions = {
@@ -57,7 +56,6 @@ export type HydrateRootOptions = {
   identifierPrefix?: string,
   onRecoverableError?: (error: mixed) => void,
   formState?: ReactFormState<any, any> | null,
-  ...
 };
 
 import {

diff --git a/packages/shared/ReactTypes.js b/packages/shared/ReactTypes.js
@@ -31,15 +31,12 @@ export type ReactProvider<T> = {
   props: {
     value: T,
     children?: ReactNodeList,
-    ...
   },
-  ...
 };
 
 export type ReactProviderType<T> = {
   $$typeof: symbol | number,
   _context: ReactContext<T>,
-  ...
 };
 
 export type ReactConsumer<T> = {
@@ -49,9 +46,7 @@ export type ReactConsumer<T> = {
   ref: null,
   props: {
     children: (value: T) => ReactNodeList,
-    ...
   },
-  ...
 };
 
 export type ReactContext<T> = {
@@ -71,7 +66,6 @@ export type ReactContext<T> = {
   // only used by ServerContext
   _defaultValue: T,
   _globalName: string,
-  ...
 };
 
 export type ServerContextJSONValue =
@@ -91,7 +85,6 @@ export type ReactPortal = {
   children: ReactNodeList,
   // TODO: figure out the API for cross-renderer implementation.
   implementation: any,
-  ...
 };
 
 export type RefObject = {
@@ -104,7 +97,7 @@ export type ReactScope = {
 
 export type ReactScopeQuery = (
   type: string,
-  props: {[string]: mixed, ...},
+  props: {[string]: mixed},
   instance: mixed,
 ) => boolean;
 

diff --git a/scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js b/scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js
@@ -22,13 +22,11 @@ export const customBubblingEventTypes: {
       skipBubbling?: ?boolean,
     }>,
   }>,
-  ...
 } = {};
 export const customDirectEventTypes: {
   [eventName: string]: $ReadOnly<{
     registrationName: string,
   }>,
-  ...
 } = {};
 
 const viewConfigCallbacks = new Map<string, ?() => ViewConfig>();