-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L5 #158
Open
sarthakSrchout
wants to merge
62
commits into
dev
Choose a base branch
from
l5
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
L5 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6918ae0.
Code Refactoring
Extract broadcasting action to a method
Push notification channels
Currently when Apn.php attempts to connect to apple push services we attempt to re-try caught exceptions if one is thrown. However, in situations where a push certificate is invalid or expired we run into infinite recursion constantly re-trying the connection without providing any feedback. The following will set a limit on the number of times we may re-try. Configurable if users define 'connection_attempts'. Default is three attempts before giving up. Feedback will be set with the last known failure reason. Original behaviour can be achieved by explicitly setting 'connection_attempts' to zero in the setConfig() assoc-array. Signed-off-by: Jamie Couture <jamie.couture@crowdspark.com>
apn.php: avoid recursion on connection failure
Add more info about notification channels
showcase the possibility to change badge number in APN example
…nto ghjer-patch-1
remove unnecessary comma
…nfig-key-defined Throw exception if service is not defined in config file.
* coding style (PSR-2)
Code refactoring
…ertion to float type Issue reference #63
…ge-numbers bitmask of JSON_BIGINT_AS_STRING
…ethod when the application is in background
Use laravel helpers to access configuration variables.
To handle FCM notification in backgrounded Android applications
…ertion to float type. Fixes #63
…ge-numbers Feature/fix gcm fcm response large numbers
FCM and GCM not sending the badge number via channel
added icon property into fcm channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n