Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen dithered and looks bad #133

Closed
Snowflake6 opened this issue Jan 4, 2021 · 5 comments · Fixed by #134
Closed

Lock screen dithered and looks bad #133

Snowflake6 opened this issue Jan 4, 2021 · 5 comments · Fixed by #134
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Snowflake6
Copy link

Snowflake6 commented Jan 4, 2021

Describe the bug
When running xochitl under oxide, and the screensaver / lock screen loads suspended.png, the image first loads cleanly, then is immediately dithered to half-brightness or something, and looks blurry.

To Reproduce
Steps to reproduce the behavior:

  1. From oxide launcher, start xochitl
  2. While xochitl is running, press the power button on top of the RM1
  3. Observe suspended.png loading cleanly (briefly)
  4. Observe an immediate dithering of the clean image

Expected behavior
A clear presentation of the image in suspended.png when the screen is locked or times out.

Screenshots
Not sure how to take a screenshot of a lock screen.

Version Information:

  • Device: reMarkable 1
  • OS: 2.5.0.27-patch_17.1.03-0-gd8286ca
  • Version: 2.0.1-beta-2

Additional context
I am using remarkable_news (https://github.com/Evidlo/remarkable_news) to dynamically change my suspended.png image. It is pulling images from picsum.photo with the following URL: https://picsum.photos/1404/1872.jpg?grayscale. This should bring in an image perfectly sized to the screen, and greyscaled.

Note: Prior to installing toltec and oxide, I was using remarkable_news and the images were coming in clean. I think this is something to do with oxide trying to "help" the screen lock action, perhaps?

@Snowflake6 Snowflake6 added bug Something isn't working to-triage This needs to be triaged labels Jan 4, 2021
@Eeems
Copy link
Collaborator

Eeems commented Jan 4, 2021

This is likely due to an issue that others have mentioned (but not opened an issue for yet) where the power button press is for some reason not actually being blocked by tarnish, and thus xochitl is also trying to handle the button press as well. This isn't a problem on the rM1 due to how it's properly blocking the button press if it's being handled.

@Witos could you include your findings (evtest etc) here?

@Snowflake6 also, for the screenshot, you can just take a photo of your tablet when the lockscreen is displayed.

@Snowflake6
Copy link
Author

@Eeems Good point on the screenshots. It sounds like the issue may be understood, but for the sake of completeness, here are two.

Expected behavior: toltec/oxide not running:
IMG_20210104_112241

Actual behavior: toltec/oxide running:
IMG_20210104_112059

@Eeems
Copy link
Collaborator

Eeems commented Jan 4, 2021

Oh wait, this is on v2.0.1. I think I had the fix to greyscale image display in v2.1 (unreleased). #93

@Eeems Eeems added duplicate This issue or pull request already exists and removed to-triage This needs to be triaged 📱 reMarkable 2 labels Jan 4, 2021
@Snowflake6
Copy link
Author

@Eeems Gah. I did try to find an existing issue, too. This can probably be closed then as it seems to be a duplicate. I'll wait for 2.1 to come out.

@Eeems
Copy link
Collaborator

Eeems commented Jan 4, 2021

I'm going to be pushing v2.0.2 here in the next little bit due to a couple of PRs that are open. I'll sneak this in as well.

@Eeems Eeems mentioned this issue Jan 4, 2021
@Eeems Eeems closed this as completed in #134 Jan 4, 2021
Eeems added a commit that referenced this issue Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants