Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect rM2 without rm2fb and fork xochitl #173

Closed
danshick opened this issue Mar 3, 2021 · 7 comments · Fixed by #185
Closed

Detect rM2 without rm2fb and fork xochitl #173

danshick opened this issue Mar 3, 2021 · 7 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@danshick
Copy link
Contributor

danshick commented Mar 3, 2021

Is your feature request related to a problem? Please describe.
Users are soft bricking their tablets if they forget to install rm2fb before oxide.

Describe the solution you'd like
Detect the rM2 device type and a working rm2fb install (similar to how reStream does). If the former is true and not the latter, just fork to Xochitl as a backup measure.

Describe alternatives you've considered
There may be a better solution long term, but this quick fix can be added fairly easily in less time.

@danshick danshick added enhancement New feature or request to-triage This needs to be triaged labels Mar 3, 2021
@Eeems Eeems removed the to-triage This needs to be triaged label Mar 3, 2021
@Eeems Eeems added this to the v2.2 milestone Mar 3, 2021
@raisjn
Copy link
Collaborator

raisjn commented Mar 21, 2021

what happens if user installs oxide and then factory resets?

@Eeems
Copy link
Collaborator

Eeems commented Mar 21, 2021

They'll need to SSH in to fix up their service files.

@raisjn
Copy link
Collaborator

raisjn commented Mar 21, 2021

they'd get locked out. i think this task is covering only half the cases and could be better to handle this at a higher level (a special file that detects if the binary for oxide is missing, as well as detects rm2fb stuff, and launches xochitl if things are out of order)

@Eeems
Copy link
Collaborator

Eeems commented Mar 21, 2021

they'd get locked out.

How? SSH over USB should still work no problem.

i think this task is covering only half the cases and could be better to handle this at a higher level (a special file that detects if the binary for oxide is missing, as well as detects rm2fb stuff, and launches xochitl if things are out of order)

If you'd like to open up a PR that does this in a clean way I'd be open to merging it. But without a rM2, I'm not really able to make much progress on this.

@raisjn
Copy link
Collaborator

raisjn commented Mar 22, 2021

if someone uses ssh keys, installs oxide (disable xochitl), then factory resets, i think they can't ssh back in

there can be a wrapper that calls oxide or draft that performs both checks

@Eeems
Copy link
Collaborator

Eeems commented Mar 22, 2021

They should still be able to use SSH keys I would expect. Depending on where the authorized_keys file is.

Eeems added a commit that referenced this issue Mar 27, 2021
@raisjn
Copy link
Collaborator

raisjn commented Mar 27, 2021

They should still be able to use SSH keys I would expect. Depending on where the authorized_keys file is.

authorized_keys is usually in ~/.ssh/. i'm pretty sure the situation i outlined is possible and i'm trying to help reduce the amount of "soft bricked" tablets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants