Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling wifi in xochitl will crash tarnish #59

Closed
Eeems opened this issue Sep 15, 2020 · 9 comments
Closed

Disabling wifi in xochitl will crash tarnish #59

Eeems opened this issue Sep 15, 2020 · 9 comments
Assignees
@Eeems
Labels
bug Something isn't working 📱 reMarkable 1
Milestone
v2.1-beta

Comments

@Eeems
Copy link
Collaborator

Eeems commented Sep 15, 2020

No description provided.

@Eeems Eeems added the bug Something isn't working label Sep 15, 2020
@Eeems Eeems added this to the v2.0-beta milestone Sep 16, 2020
@Eeems Eeems pinned this issue Sep 16, 2020
@Eeems Eeems self-assigned this Sep 23, 2020
@Eeems
Copy link
Collaborator Author

Eeems commented Sep 26, 2020

This seems to be due to how the dbus interface is handled. When you toggle off wifi in xochitl all the dbus interface objects get deregistered. I need some way to catch that it's been turned off by xochitl and clean up before it can crash.

@Eeems Eeems modified the milestones: v2.0-beta, v2.1-beta Sep 26, 2020
@Eeems
Copy link
Collaborator Author

Eeems commented Dec 10, 2020

Would someone be able to test this on the rM2 as well? @Witos @raisjn ?

@Jcwscience
Copy link

The bug does not appear to effect the rM2. Just checked and it enable/disabled fine

@Eeems
Copy link
Collaborator Author

Eeems commented Dec 27, 2020

What steps did you use? If you just toggle it off an on again it wont trigger the crash.

@Jcwscience
Copy link

I just toggled it. What are the steps for the crash?

@Eeems
Copy link
Collaborator Author

Eeems commented Dec 27, 2020

I believe I connected to wifi in oxide, turned it off in xochitl and then went back to the launcher to look at the wifi menu.

@Jcwscience
Copy link

Following those steps, it doesn't crash but the wifi menu in oxide doesn't reflect the change, it still shows as enabled but not connected. If you click "turn off wifi"  even though it's already off, and turn it back on again, everything works as expected.

@Eeems
Copy link
Collaborator Author

Eeems commented Dec 27, 2020

Interesting, I wonder what is different about the wpa_supplicant interface.

Eeems added a commit that referenced this issue Dec 29, 2020
@Eeems
Fix #59
676623d
@Eeems Eeems closed this as completed Dec 29, 2020
@Eeems Eeems reopened this Dec 29, 2020
@Eeems
Copy link
Collaborator Author

Eeems commented Dec 29, 2020

Thought I found a fix, but further testing showed it wasn't actually working. From the debugging I'm doing, this seems to be due to trying to access an object that has been free'd already by Qt. Not sure why this is happening.

@Eeems Eeems closed this as completed Dec 30, 2020
Eeems added a commit that referenced this issue Dec 30, 2020
@Eeems
Finally fix #59
4aa33a2
Eeems added a commit that referenced this issue Jan 9, 2021
@Eeems
v2.1 (#98)
33ee9fa 
* Use QT framework for handling suspend image

* Remove fb2png dependency and simplify screenshot logic

* Resolve compiler warnings


* Notifications API

* Clean up output from isConnected check

* Fix notification API in rot

* Fix resume recalling screen

* Have oxide power menu respect inhibits

* Fix #104

* Fix #106 by removing application entries if they are invalid on load

* Fix #105

* Fix #116

* Add option to show date in launcher

* Add shorthand for device settings and add in code to remove/add wifi module on suspend/resume

* Fix #112

* Added ability to modify on* events

* Add calendar menu when clock is tapped on

* Fix #27

* Fix #91

* Fix #100

* Fix wifi showing as disconnected when it's actually off

* Fix #59

* Switch to using deletelater which doesn't work :/

* More attempts to fix crash when xochtil disables wifi

* Finally fix #59

* Fix #122

* Add method to reload applications from disk

* Force application environment/program to update properly

* Get initial chroot jails setup

* Fully add user/group/workingDirectory logic

* Fix #124

* Allow adding directories to chroot

* Clean up process exit code

* Fix #125

* Clean up application quitting more. Add aboutToQuit signal to API

* Flush out Screenshot API

* Fix #128

* Allow users to click on notifications in oxide

* Make fret's notifications a little smarter

* Add lockscreen application

* Fix bug where applications are not being stored properly

* Speed up erode list and fix issue with draft import

* Update Makefile

* Allow changing process manager application, and only allow one reload at once

* Add permissions

* Support sleeping.png

* Fix #109 and add lock option

* Fix #97

* Fix #138

* Fix #100

* Add history queue of applications so that the lockscreen with open the recent app
@Eeems Eeems unpinned this issue Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eeems Eeems

Labels
bug Something isn't working 📱 reMarkable 1
Projects
None yet
Milestone
v2.1-beta
Development

No branches or pull requests
2 participants
@Eeems @Jcwscience